From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 14ED9156
 for <dev@dpdk.org>; Tue, 12 Nov 2013 18:21:01 +0100 (CET)
Received: by mail-wi0-f173.google.com with SMTP id ey11so4044253wid.12
 for <dev@dpdk.org>; Tue, 12 Nov 2013 09:21:57 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc
 :references:in-reply-to:mime-version:content-type
 :content-transfer-encoding:message-id;
 bh=45h1oMFg17iFeniOGVwLPKoF5DlzlQyBwD7dGoH3ipo=;
 b=cxWOq9UZ0sFWdjsEAxNAsZQm20Hve7xYXUyyP2D96nF1c6mIxAWy+qPZSdrjtHYlO6
 SuHWfcr+2+rl03vnEA1Z7V01LhDbCnxcsNOQ/wE4HoF7kYDWVvgI+G8qr7NxeOLMS9l5
 zQdzulWLAr21jeMVAxLlCw5MdNmu46Ya8gGXvjUPXP/7ekjfBMP0bDiQ59gBI5OyBQMC
 l+1s//JlFkYm+2LmCV3UZ7UmOWR9rgNGEkt3md/HEfULFvkKw7n0UN31i/tW1stz+Mkc
 ZvyjvYAMo+soCeoWmKmRS224dXfOgVU1/jWJPKkhC6TCQ9lccB0KARJZWEtjKd6sShvB
 oROg==
X-Gm-Message-State: ALoCoQkX0ySJp0j8OrDgiBogEggdMS9EP3RC5Z5fH9QSX65kTNTSccYxTT3K8/EqcDaQD01ltcGk
X-Received: by 10.194.47.142 with SMTP id d14mr1828962wjn.66.1384276917319;
 Tue, 12 Nov 2013 09:21:57 -0800 (PST)
Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id qc10sm46639016wic.9.2013.11.12.09.21.55
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 12 Nov 2013 09:21:56 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Organization: 6WIND
To: Bryan Benson <bmbenson@amazon.com>
Date: Tue, 12 Nov 2013 18:21:52 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <1383940042-31770-1-git-send-email-bmbenson@amazon.com>
 <52824E21.20405@6wind.com>
In-Reply-To: <52824E21.20405@6wind.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201311121821.53077.thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: Fix offloading bits when RX bulk
	alloc is used.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Nov 2013 17:21:02 -0000

12/11/2013 16:49, Ivan Boule :
> On 11/08/2013 08:47 PM, Bryan Benson wrote:
> > This is a fix for the ixgbe hardware offload flags not being set when
> > bulk alloc RX is used. The issue was caused by masking off the bits that
> > store the hardware offload values in the status_error field to retrieve
> > the done bit for the descriptor.
> > 
> > Commit 7431041062b9fd0555bac7ca4abebc99e3379fa5 in DPDK-1.3.0 introduced
> > bulk dequeue, which included the bug. ---
> > 
> >   lib/librte_pmd_ixgbe/ixgbe_rxtx.c |   13 +++++++------
> >   1 file changed, 7 insertions(+), 6 deletions(-)
> 
> Acked.

Applied.

Good catch. Thanks
-- 
Thomas