* [dpdk-dev] [PATCH] mk: fix EXTRA_LDFLAGS override
@ 2013-11-15 14:22 Julien Courtat
2013-11-15 14:56 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Julien Courtat @ 2013-11-15 14:22 UTC (permalink / raw)
To: dev
The GCC prefix -Wl was ignored because the command line value has higher priority.
It ended in impossibilty for GCC to pass parameters to LD.
The prefixed value must override the command line one.
Signed-off-by: Julien Courtat <julien.courtat@6wind.com>
---
mk/rte.app.mk | 2 +-
mk/rte.shared.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index 728e5b5..d2ce5c0 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -182,7 +182,7 @@ ifeq ($(LINK_USING_CC),1)
comma := ,
LDLIBS := $(addprefix -Wl$(comma),$(LDLIBS))
LDFLAGS := $(addprefix -Wl$(comma),$(LDFLAGS))
-EXTRA_LDFLAGS := $(addprefix -Wl$(comma),$(EXTRA_LDFLAGS))
+override EXTRA_LDFLAGS := $(addprefix -Wl$(comma),$(EXTRA_LDFLAGS))
O_TO_EXE = $(CC) $(CFLAGS) $(LDFLAGS_$(@)) \
-Wl,-Map=$(@).map,--cref -o $@ $(OBJS-y) $(LDFLAGS) $(EXTRA_LDFLAGS) $(LDLIBS)
else
diff --git a/mk/rte.shared.mk b/mk/rte.shared.mk
index 7a3a78f..e9be02d 100644
--- a/mk/rte.shared.mk
+++ b/mk/rte.shared.mk
@@ -61,7 +61,7 @@ ifeq ($(LINK_USING_CC),1)
comma := ,
LDLIBS := $(addprefix -Wl$(comma),$(LDLIBS))
LDFLAGS := $(addprefix -Wl$(comma),$(LDFLAGS))
-EXTRA_LDFLAGS := $(addprefix -Wl$(comma),$(EXTRA_LDFLAGS))
+override EXTRA_LDFLAGS := $(addprefix -Wl$(comma),$(EXTRA_LDFLAGS))
O_TO_SO = $(CC) $(LDFLAGS) $(LDFLAGS_$(@)) $(EXTRA_LDFLAGS) \
-shared -o $@ $(OBJS-y) $(LDLIBS)
else
--
1.7.2.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: fix EXTRA_LDFLAGS override
2013-11-15 14:22 [dpdk-dev] [PATCH] mk: fix EXTRA_LDFLAGS override Julien Courtat
@ 2013-11-15 14:56 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2013-11-15 14:56 UTC (permalink / raw)
To: Julien Courtat; +Cc: dev
15/11/2013 15:22, Julien Courtat :
> The GCC prefix -Wl was ignored because the command line value has higher
> priority. It ended in impossibilty for GCC to pass parameters to LD.
> The prefixed value must override the command line one.
>
> Signed-off-by: Julien Courtat <julien.courtat@6wind.com>
Acked and applied.
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-15 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-15 14:22 [dpdk-dev] [PATCH] mk: fix EXTRA_LDFLAGS override Julien Courtat
2013-11-15 14:56 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).