Re: [dpdk-dev] Question: Can't make pcap and refcnt to match

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hello,

26/11/2013 16:42, Robert Sanford :
> I've been meaning to submit a change, but I'm not familiar with the
> process.

The process is to send your patch with git (format-patch + send-email).
You have to set a short title and a longer commit log explaining what was the 
problem and how you fix it.
The commit log must have a Signed-off-by line (see "Developer's Certificate of 
Origin" in https://www.kernel.org/doc/Documentation/SubmittingPatches

> + /*
> + * Fix buffer overflow problems.
> + * 1. Frame may be longer than mbuf.
> + * 2. Capture length (caplen) may be less than original packet length.
> + */

This should be in the commit log.
Keep only comments needed to understand the code.

> + /****
> + RTE_LOG(INFO, PMD, "eth_pcap_rx: i=%u caplen=%u framelen=%u tail=%u
> len=%u\n",
> + i, header.caplen, header.len, tailroom, len);
> + ****/

Why it is commented out ?
If it's important, it is an INFO log.
If it's useful when debugging, set it to DEBUG.
If it's a temporary debug, remove it.

By the way, thank you for your patch.
-- 
Thomas