From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f52.google.com (mail-bk0-f52.google.com [209.85.214.52]) by dpdk.org (Postfix) with ESMTP id 79E55DE0 for ; Tue, 26 Nov 2013 17:04:17 +0100 (CET) Received: by mail-bk0-f52.google.com with SMTP id u14so2649657bkz.25 for ; Tue, 26 Nov 2013 08:05:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc :references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=f6EoH+K7CA1lanM7lyVYi6Iek5Ktu+2VtoQGpTrS1zk=; b=MVkFB5qrRkTuz0Mf+UlX22OjHd29hUxnsL41yuGL05/vb+yGmqzzdPrE4IC717wv9x Ngv9Dni9yc2JCLy/zoEr1JPIqlaOVS1Dz80M/ryCMdoMaqyjgXFcu31YwXFvWm0pEDQr 4aQKB2q8b8r8fr6cXNYYBsM8WwfxpYeng+DFMcscJMgHJimN6o7/ncDwNIsVrJcSBZP8 3miD3eYwl60zMEAe46kvbGxe3H10+sRHXLi+lTJGmOqKFAUPDiJH15R4RkyEDvWgZ/Jb kUecWZNwhJccBIWVj7iAqIYTV+ANMvV/twId5xqI3sgaaM0F1V3wJ4MKyQGSl1Sgq+wz OLSQ== X-Gm-Message-State: ALoCoQnKzLODtcdTGxGx1CPaJPilxeg9ZZ+Y5aCKG4AKYnzJTbqGlwaiweGAxV2XRnDpGaJkqXzs X-Received: by 10.204.229.12 with SMTP id jg12mr391042bkb.79.1385481917095; Tue, 26 Nov 2013 08:05:17 -0800 (PST) Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id pk7sm51752039bkb.2.2013.11.26.08.05.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Nov 2013 08:05:16 -0800 (PST) From: Thomas Monjalon Organization: 6WIND To: Robert Sanford Date: Tue, 26 Nov 2013 17:05:13 +0100 User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) References: <59AF69C657FD0841A61C55336867B5B01A977A55@IRSMSX103.ger.corp.intel.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201311261705.14030.thomas.monjalon@6wind.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] Question: Can't make pcap and refcnt to match X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Nov 2013 16:04:17 -0000 Hello, 26/11/2013 16:42, Robert Sanford : > I've been meaning to submit a change, but I'm not familiar with the > process. The process is to send your patch with git (format-patch + send-email). You have to set a short title and a longer commit log explaining what was the problem and how you fix it. The commit log must have a Signed-off-by line (see "Developer's Certificate of Origin" in https://www.kernel.org/doc/Documentation/SubmittingPatches > + /* > + * Fix buffer overflow problems. > + * 1. Frame may be longer than mbuf. > + * 2. Capture length (caplen) may be less than original packet length. > + */ This should be in the commit log. Keep only comments needed to understand the code. > + /**** > + RTE_LOG(INFO, PMD, "eth_pcap_rx: i=%u caplen=%u framelen=%u tail=%u > len=%u\n", > + i, header.caplen, header.len, tailroom, len); > + ****/ Why it is commented out ? If it's important, it is an INFO log. If it's useful when debugging, set it to DEBUG. If it's a temporary debug, remove it. By the way, thank you for your patch. -- Thomas