* [dpdk-dev] [PATCH] mk: fix pcap build with empty LIBPCAP_CFLAGS
@ 2013-12-06 16:48 Robert Sanford
2013-12-10 9:40 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Robert Sanford @ 2013-12-06 16:48 UTC (permalink / raw)
To: dev
Fix pcap build - In rte.sdkbuild.mk with CONFIG_RTE_LIBRTE_PMD_PCAP=y,
we error-exit if LIBPCAP_CFLAGS is empty. On some distros (e.g., Centos
6.4),
it is normal for "pcap-config --cflags" to output only a newline, because
pcap
header files reside in /usr/include/.
Solution is to remove the line that checks whether LIBPCAP_CFLAGS is empty.
---
mk/rte.sdkbuild.mk | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
index 33bed57..d9b6802 100644
--- a/mk/rte.sdkbuild.mk
+++ b/mk/rte.sdkbuild.mk
@@ -42,7 +42,6 @@ endif
ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
LIBPCAP_CFLAGS ?= $(shell pcap-config --cflags)
-$(if $(LIBPCAP_CFLAGS),,$(error LIBPCAP_CFLAGS is undefined))
EXTERNAL_LIB_CFLAGS += $(LIBPCAP_CFLAGS)
endif
--
1.7.1
Signed-off-by: Robert Sanford <rsanford@prolexic.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: fix pcap build with empty LIBPCAP_CFLAGS
2013-12-06 16:48 [dpdk-dev] [PATCH] mk: fix pcap build with empty LIBPCAP_CFLAGS Robert Sanford
@ 2013-12-10 9:40 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2013-12-10 9:40 UTC (permalink / raw)
To: Robert Sanford; +Cc: dev
06/12/2013 17:48, Robert Sanford :
> Fix pcap build - In rte.sdkbuild.mk with CONFIG_RTE_LIBRTE_PMD_PCAP=y,
> we error-exit if LIBPCAP_CFLAGS is empty. On some distros (e.g., Centos
> 6.4),
> it is normal for "pcap-config --cflags" to output only a newline, because
> pcap
> header files reside in /usr/include/.
> Solution is to remove the line that checks whether LIBPCAP_CFLAGS is empty.
Acked and applied.
--
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-10 9:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-06 16:48 [dpdk-dev] [PATCH] mk: fix pcap build with empty LIBPCAP_CFLAGS Robert Sanford
2013-12-10 9:40 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).