DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Mats Liljegren <liljegren.mats2@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] RFC: Introduce host_ifname field to struct rte_eth_dev_info
Date: Thu, 2 Jan 2014 14:51:11 +0100	[thread overview]
Message-ID: <201401021451.11321.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <CA+xJJ1-F5Xi6dx8o1Dy12a_5Kz0_DVr=TSJVfxmQA1OkJFCG2A@mail.gmail.com>

Hello,

04/12/2013 16:39, Mats Liljegren :
> The only place where I know which core will handle which pcap
> interface, is within my DPDK application. But DPDK did not save the
> host interface name anywhere, so it was nowhere to be found.
> 
> I created a patch for this, found below. Is this something that could
> be upstreamed?

Thank you for your patch.
I think it's a good idea to store OS ifname in rte_eth_dev_info.

Could you please split generic declaration and pcap implementation in 2 
patches ?

We should maybe keep ifname as variable name (you are using host_ifname and 
iface_name).

-- 
Thomas

  reply	other threads:[~2014-01-02 13:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04 15:39 Mats Liljegren
2014-01-02 13:51 ` Thomas Monjalon [this message]
2014-01-02 16:36 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201401021451.11321.thomas.monjalon@6wind.com \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=liljegren.mats2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).