From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id B0AFD156 for ; Thu, 2 Jan 2014 14:50:04 +0100 (CET) Received: by mail-wg0-f47.google.com with SMTP id n12so12235061wgh.26 for ; Thu, 02 Jan 2014 05:51:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc :references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=IupuayoswZ2mvU8meOFBWSdB9EL2eSBaGJSBFNSGfUU=; b=ZD9ek7lahEqD+1XXTCUQCpY5jLuCIxb8ciuZbiAO7ItoPEDf+rMsfwg/VyxT5N2A6I FaeFcpDRvLW8GRLGzxmvZq3NfxnN76oGesSkAMiwYQaCE2txB2W3TY+UxR+BX4rHOnL8 6OC/AlhabdaZPv1rxlRXLDwWLxQScH/cxZciXt5K/h1mKn2mgfi6mE8cyuuAhil/4GY1 ACXlfPFiA+arACyWsM37ZN8lZIuLMMynXekylDV/sWve209FMxJsylJjDGMPdcO18rr0 cjJO48CLiccFJnPQuHNp+LPq6mCgdxBP/lk4rk6br4xkYQ1wNQ48lCkLMp+U625qVOLO naUQ== X-Gm-Message-State: ALoCoQmsvDUDCInVaO7GP4JLtFTVYeEn3DN9pRYA+2GrkXMoKFuW1Hp+o81i0J+iB6sl1ZeoyHcI X-Received: by 10.194.104.42 with SMTP id gb10mr57235449wjb.16.1388670673437; Thu, 02 Jan 2014 05:51:13 -0800 (PST) Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id hv3sm53218182wib.5.2014.01.02.05.51.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Jan 2014 05:51:12 -0800 (PST) From: Thomas Monjalon Organization: 6WIND To: Mats Liljegren Date: Thu, 2 Jan 2014 14:51:11 +0100 User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201401021451.11321.thomas.monjalon@6wind.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] RFC: Introduce host_ifname field to struct rte_eth_dev_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jan 2014 13:50:05 -0000 Hello, 04/12/2013 16:39, Mats Liljegren : > The only place where I know which core will handle which pcap > interface, is within my DPDK application. But DPDK did not save the > host interface name anywhere, so it was nowhere to be found. > > I created a patch for this, found below. Is this something that could > be upstreamed? Thank you for your patch. I think it's a good idea to store OS ifname in rte_eth_dev_info. Could you please split generic declaration and pcap implementation in 2 patches ? We should maybe keep ifname as variable name (you are using host_ifname and iface_name). -- Thomas