From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Asias He <asias.hejun@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [virtio-net-pmd PATCH] pmd: Fix pci_id match
Date: Mon, 6 Jan 2014 10:38:53 +0100 [thread overview]
Message-ID: <201401061038.53997.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <1388815654-2088-1-git-send-email-asias.hejun@gmail.com>
Hello Asias,
04/01/2014 07:07, Asias He :
> Hex numbers in /proc/ioports are lowercase. we should make it lowercase
> in pci_id as well. Otherwise devices like:
>
> 00:0a.0 Ethernet controller: Red Hat, Inc Virtio network device
>
> would not be handled by virtio-net-pmd.
>
> Signed-off-by: Asias He <asias.hejun@gmail.com>
Good catch !
I have acked and applied it with this title:
pmd: fix PCI id match when probing
I think we should distinguish such patch for an extension from other ones.
I suggest using --subject-prefix 'virtio-net-pmd PATCH'
Thank you
--
Thomas
prev parent reply other threads:[~2014-01-06 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 6:07 [dpdk-dev] [PATCH] " Asias He
2014-01-06 9:38 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401061038.53997.thomas.monjalon@6wind.com \
--to=thomas.monjalon@6wind.com \
--cc=asias.hejun@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).