From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by dpdk.org (Postfix) with ESMTP id 48FDC3F9 for ; Mon, 6 Jan 2014 10:37:45 +0100 (CET) Received: by mail-we0-f172.google.com with SMTP id p61so15762918wes.17 for ; Mon, 06 Jan 2014 01:38:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc :references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=H3ugcY57mLuTN7m441msZLqFL47dscrHHmX+w+1OMHI=; b=gROfMydRhT4PMcaNvH9j8od5X+S02gGhsmjRRvWF3MP2qUm0yEVIm5MyQpqRezPe8c 0sv2KX1aRSAHcUecvrNfDvO1ByyYJ7WaKbaP0n2ObL8ouFryBKs7Wc65DR138FW8LrWz hxENLDpdzTnErSUBdDVzlUAxIYnkR7+yv9dmHGuDzhOq+LX34p2BO4EXxxZm3+KJGOhE yxjF5YFVACdOg0hcVBRGbWQ6Q52IgfU1zgI4GuBBLoLp0OMjJA80vW0H70H6Eh0HneBr dWUmSk0koxjVeGfSMcx8ZtdfDZANetodsJT+cQdBOaWjiQ7VQQYfI8ElJLQNus9TTn3q /fHQ== X-Gm-Message-State: ALoCoQkGbDxfduNpN/JxF3yNNNZYhDs6EaDEzBTuCDwJmUpEKocXuzHExTbn04Lw0dKRrN5i2gKi X-Received: by 10.194.104.42 with SMTP id gb10mr71858258wjb.16.1389001136454; Mon, 06 Jan 2014 01:38:56 -0800 (PST) Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id jw4sm42090960wjc.20.2014.01.06.01.38.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jan 2014 01:38:55 -0800 (PST) From: Thomas Monjalon Organization: 6WIND To: Asias He Date: Mon, 6 Jan 2014 10:38:53 +0100 User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) References: <1388815654-2088-1-git-send-email-asias.hejun@gmail.com> In-Reply-To: <1388815654-2088-1-git-send-email-asias.hejun@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201401061038.53997.thomas.monjalon@6wind.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [virtio-net-pmd PATCH] pmd: Fix pci_id match X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jan 2014 09:37:45 -0000 Hello Asias, 04/01/2014 07:07, Asias He : > Hex numbers in /proc/ioports are lowercase. we should make it lowercase > in pci_id as well. Otherwise devices like: > > 00:0a.0 Ethernet controller: Red Hat, Inc Virtio network device > > would not be handled by virtio-net-pmd. > > Signed-off-by: Asias He Good catch ! I have acked and applied it with this title: pmd: fix PCI id match when probing I think we should distinguish such patch for an extension from other ones. I suggest using --subject-prefix 'virtio-net-pmd PATCH' Thank you -- Thomas