From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Daniel Kan <dan@nyansa.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix RSS rx by setting mq_mode
Date: Mon, 13 Jan 2014 11:31:06 +0100 [thread overview]
Message-ID: <201401131131.06203.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <1389408367-19376-1-git-send-email-dan@nyansa.com>
Hello,
11/01/2014 03:46, Daniel Kan:
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1546,6 +1546,9 @@ init_port_config(void)
> if (nb_rxq > 0) {
> port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
> port->dev_conf.rx_adv_conf.rss_conf.rss_hf = rss_hf;
> + if (nb_rxq > 1 && rss_hf != 0) {
> + port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_RSS;
> + }
The fix looks good. Thanks.
Please, could you add a detailed explanation and a signed-off as described in
the guidelines:
http://dpdk.org/dev#send
I think it's a good idea to point to the commit which has introduced the bug.
Note also that "RSS rx" may be simply "RSS".
Thank you
--
Thomas
next prev parent reply other threads:[~2014-01-13 10:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 2:46 Daniel Kan
2014-01-13 10:31 ` Thomas Monjalon [this message]
2014-01-13 11:18 ` Ananyev, Konstantin
2014-01-13 11:32 ` Thomas Monjalon
2014-01-13 19:17 ` [dpdk-dev] [PATCH v2] app/testpmd: fix RSS " Daniel Kan
2014-01-14 17:42 ` Maxime Leroy
2014-01-14 19:57 ` Daniel Kan
2014-01-14 21:34 ` Thomas Monjalon
2014-01-16 0:27 ` [dpdk-dev] [PATCH v3] Daniel Kan
2014-01-16 0:31 ` [dpdk-dev] [PATCH v3] app/testpmd: fix RSS rx by setting mq_mode Daniel Kan
2014-01-16 12:34 ` Maxime Leroy
2014-01-17 11:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401131131.06203.thomas.monjalon@6wind.com \
--to=thomas.monjalon@6wind.com \
--cc=dan@nyansa.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).