From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) by dpdk.org (Postfix) with ESMTP id B58F0DE0 for ; Mon, 13 Jan 2014 11:29:55 +0100 (CET) Received: by mail-we0-f174.google.com with SMTP id x55so2795776wes.33 for ; Mon, 13 Jan 2014 02:31:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc :references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=VltzTsjgq2g5jR/A3UEiLHuLoEZtUmleWIRZsEiBp1Y=; b=hQqdw2zhvp4xBMMaOBgfOTfZBNvYPBPovk0Ex0D/gHmbi351UXDtrk3vvhZ2rc1Cxf JUOHf3EEFURUb/HLTd67IHewVf8hcxouPHQcXcz1KL2BOSiPXNM8LvTG3vJQnBbu/X/Y htvoqpl+3d4Lnc6W2GFA7TeawPasTbGzeljkqK2KzFhg8je5GhqAIgyGuYjxXBwyvIg1 Mss0jJgzMPmbkQr3/MwdQuL4XOeCX8STB4v4HmHOGmAmdtls/d+LZf7cAiaSNn/GJSpu 4WG5J5CMEdAe2ZYe2eDlwwHEI3JoLOpAlD0pqr+Q8LkeajefP9KIY8vQiZlSgtCSxiBC tmhQ== X-Gm-Message-State: ALoCoQmprCTjBDZjI0SnXLoATjSQPDxsrrOq2SP53Z20qxLtqUcMxIOAeHnjiREqPOreljLX9C9m X-Received: by 10.194.59.164 with SMTP id a4mr166797wjr.95.1389609068789; Mon, 13 Jan 2014 02:31:08 -0800 (PST) Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id cy10sm11036529wjb.6.2014.01.13.02.31.07 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jan 2014 02:31:08 -0800 (PST) From: Thomas Monjalon Organization: 6WIND To: Daniel Kan Date: Mon, 13 Jan 2014 11:31:06 +0100 User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) References: <1389408367-19376-1-git-send-email-dan@nyansa.com> In-Reply-To: <1389408367-19376-1-git-send-email-dan@nyansa.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201401131131.06203.thomas.monjalon@6wind.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix RSS rx by setting mq_mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jan 2014 10:29:56 -0000 Hello, 11/01/2014 03:46, Daniel Kan: > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1546,6 +1546,9 @@ init_port_config(void) > if (nb_rxq > 0) { > port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL; > port->dev_conf.rx_adv_conf.rss_conf.rss_hf = rss_hf; > + if (nb_rxq > 1 && rss_hf != 0) { > + port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_RSS; > + } The fix looks good. Thanks. Please, could you add a detailed explanation and a signed-off as described in the guidelines: http://dpdk.org/dev#send I think it's a good idea to point to the commit which has introduced the bug. Note also that "RSS rx" may be simply "RSS". Thank you -- Thomas