DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Loop back mode of the KNI
Date: Fri, 17 Jan 2014 16:35:37 +0100	[thread overview]
Message-ID: <201401171635.37605.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A6989BE@SHSMSX104.ccr.corp.intel.com>

17/01/2014 15:28, Zhang, Helin:
> The final fix for that could be like below.
> 
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> @@ -311,7 +311,6 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)
>                         skb_reserve(skb, 2);
>                         memcpy(skb_put(skb, len), data_kva, len);
>                         skb->dev = dev;
> -                       skb->protocol = eth_type_trans(skb, dev);
>                         skb->ip_summed = CHECKSUM_UNNECESSARY;
>                         dev_kfree_skb(skb);
>                 }
> @@ -327,7 +326,6 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)
>                         skb_reserve(skb, 2);
>                         memcpy(skb_put(skb, len), data_kva, len);
>                         skb->dev = dev;
> -                       skb->protocol = eth_type_trans(skb, dev);
>                         skb->ip_summed = CHECKSUM_UNNECESSARY;
> 
>                         kni->stats.rx_bytes += len;

Thanks for sharing.
Please, could you send a real patch with title, detailed explanation and 
sign-off as suggested in http://dpdk.org/dev#send ?
We should integrate such fix as soon as possible in the current branch in 
order to provide better user experience.

-- 
Thomas

      reply	other threads:[~2014-01-17 15:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 16:36 Daniel Kaminsky
2013-12-25  0:50 ` Zhang, Helin
2013-12-25  6:57   ` Daniel Kaminsky
2014-01-17 11:19     ` Thomas Monjalon
2014-01-17 14:28       ` Zhang, Helin
2014-01-17 15:35         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201401171635.37605.thomas.monjalon@6wind.com \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).