From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f178.google.com (mail-we0-f178.google.com
 [74.125.82.178]) by dpdk.org (Postfix) with ESMTP id 177E49A
 for <dev@dpdk.org>; Fri, 17 Jan 2014 16:34:25 +0100 (CET)
Received: by mail-we0-f178.google.com with SMTP id t60so4726396wes.9
 for <dev@dpdk.org>; Fri, 17 Jan 2014 07:35:40 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc
 :references:in-reply-to:mime-version:content-type
 :content-transfer-encoding:message-id;
 bh=bP0gBAXFaSt9X/X/tRGDVOJktFWujSrhVJil8g+xTBA=;
 b=f31Yu6UPPE4qNJWUbxaThGSOVepTN/v+qJOXIV4XvJDO6sy2IwN7iWI/1zZ4Arlf0U
 2he3JyvmwwoRiJqBRUYplvv3FS9uEUoCRUzkvFQweUMng5dUMEbVc+iI60/4Goo/pN0s
 b33IoSVGH41NcGm18+aoXpqtp5tw5r4bL2JXwmIDGPnal+NWIZLp5cuOi1h0EgezrJCn
 XH1h73a5Whz1X89M9Z6ICaIVOTP84kdJP/vy2BtjGcLQVmAQPQxU129Cl6zgj9QdOhnz
 oFbOTYIQd4sKFG5EHD1R+a8ypcfOu3S4lAmE7M7+OFvDe1Hvhh5e2qQFhY+bgr22pnJk
 EfAA==
X-Gm-Message-State: ALoCoQltAj/ZnlGIoF/HZcPnJccfBEgjJ7tGByF8BFcv8wXPftMeb42MzBY/jLNcuu3as5n+yosb
X-Received: by 10.194.104.39 with SMTP id gb7mr2595827wjb.69.1389972940595;
 Fri, 17 Jan 2014 07:35:40 -0800 (PST)
Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id gd5sm3777026wic.0.2014.01.17.07.35.38
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 17 Jan 2014 07:35:39 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Organization: 6WIND
To: "Zhang, Helin" <helin.zhang@intel.com>
Date: Fri, 17 Jan 2014 16:35:37 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <CA+8v-Jz=S3ReQ=Bp=7FNXOs_61mwBxJ1QaaCc14a_vum1ApnXw@mail.gmail.com>
 <201401171219.41797.thomas.monjalon@6wind.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A6989BE@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A6989BE@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201401171635.37605.thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Loop back mode of the KNI
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2014 15:34:26 -0000

17/01/2014 15:28, Zhang, Helin:
> The final fix for that could be like below.
> 
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> @@ -311,7 +311,6 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)
>                         skb_reserve(skb, 2);
>                         memcpy(skb_put(skb, len), data_kva, len);
>                         skb->dev = dev;
> -                       skb->protocol = eth_type_trans(skb, dev);
>                         skb->ip_summed = CHECKSUM_UNNECESSARY;
>                         dev_kfree_skb(skb);
>                 }
> @@ -327,7 +326,6 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)
>                         skb_reserve(skb, 2);
>                         memcpy(skb_put(skb, len), data_kva, len);
>                         skb->dev = dev;
> -                       skb->protocol = eth_type_trans(skb, dev);
>                         skb->ip_summed = CHECKSUM_UNNECESSARY;
> 
>                         kni->stats.rx_bytes += len;

Thanks for sharing.
Please, could you send a real patch with title, detailed explanation and 
sign-off as suggested in http://dpdk.org/dev#send ?
We should integrate such fix as soon as possible in the current branch in 
order to provide better user experience.

-- 
Thomas