From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 53F57DE0 for ; Fri, 17 Jan 2014 18:31:51 +0100 (CET) Received: by mail-wi0-f179.google.com with SMTP id hr1so1015278wib.0 for ; Fri, 17 Jan 2014 09:33:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc :references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; bh=MCfL9lEa0jDgHi98mIHotazf9OHYeGRBYrcIZVMCrF4=; b=LzGpo6jaGJRz0OU9tca7tqDC3K25NFdjWreFiYRxj+06idUJy+GJsvh2cPLgs4OCiA UEpv37zgg2FxD5zqnZhCFgSFkvx0uG1b7/9uGgKBG/6xVY1zVFp2pVLI6nQ67EkeIM4e QlxP80p0ESDj5v/QjJTYGiKVUrGoYS1dqPw0Bcz1bP3rM23J8sE/Z/iQLXr2BS3MwrlU myI6SKFKNfBr8BT7hW2fM2Ps7FQrYWiRjJ6DaisMa//jSND8nYw39y1h2CCCnN9DoKk0 rnas4Ql6bYtQBCL57UqYBULrAMoZQlivn5k3vglxKcKD1dXp/2sMr+EvvfNdkOSPRPyX 7vUg== X-Gm-Message-State: ALoCoQmXd6VIna50vQP4AoYzWvCKFn5z4K5bd0PgT5jMNeTcJ40zxiJQ18VYz7N+lENxLrHuOa0v X-Received: by 10.180.95.105 with SMTP id dj9mr3844363wib.22.1389979985137; Fri, 17 Jan 2014 09:33:05 -0800 (PST) Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id pl7sm10014521wjc.16.2014.01.17.09.33.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jan 2014 09:33:04 -0800 (PST) From: Thomas Monjalon Organization: 6WIND To: Mats Liljegren Date: Fri, 17 Jan 2014 18:33:02 +0100 User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; ) References: <1389274977-53532-1-git-send-email-liljegren.mats2@gmail.com> <1389274977-53532-2-git-send-email-liljegren.mats2@gmail.com> In-Reply-To: <1389274977-53532-2-git-send-email-liljegren.mats2@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201401171833.02597.thomas.monjalon@6wind.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: Introduce if_index field to struct rte_eth_dev_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jan 2014 17:31:52 -0000 what about this title? "ethdev: introduce if_index in device info" > This field is intended for pcap to describe the name of the interface > as known to Linux. It is an interface index, but can be translated into > an interface name using if_indextoname() function. > > When using pcap, interrupt affinity becomes important, and this field > gives the application a chance to ensure that interrupt affinity is set > to the lcore handling the device. > > Signed-off-by: Mats Liljegren > [...] > + unsigned int if_index; /**< Index to bounded host interface, or 0 if > none. Use if_indextoname() to translate into an interface name. */ I'd split this long line like this: + unsigned if_index; /**< Index to bounded host interface, or 0 if none. + Use if_indextoname() to translate into an interface name. */ -- Thomas