From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f180.google.com (mail-we0-f180.google.com
 [74.125.82.180]) by dpdk.org (Postfix) with ESMTP id 77BD29A
 for <dev@dpdk.org>; Fri, 17 Jan 2014 18:47:41 +0100 (CET)
Received: by mail-we0-f180.google.com with SMTP id q59so4776895wes.25
 for <dev@dpdk.org>; Fri, 17 Jan 2014 09:48:56 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc
 :references:in-reply-to:mime-version:content-type
 :content-transfer-encoding:message-id;
 bh=3ZtPUyHUhr4O07/0aYdWDCyYYA+4zhUli9Inl/xl/EM=;
 b=FAxOgrHD0yT4qJ2Bls3s11y21xy71X56Vanx7XU1KVfPTRSaqQl6zOcoTnZ6RgAwB1
 mlDet55nmP3CUazWIavBo0fT2VVLRsxWfXi6m+CzmoGti2FrVRsZ8ow7f0n6aP7xaL1Z
 Wz1FFlLiTuGjeKlJfpyWJTXeSsv+XsRjYff5b8P2Tp9PZzh6Nplth5hHvsYlK1jDsZgB
 oZ7crKKFzoUBdl14G7hVNt/cC9bkjkHnKtodfvZ8TUh9Um45d/2+u2qLAqjibwyVzJMv
 2WyjjN8G8G7d4Q8O/6RtYOUlYWssChLHnEcbkzpRLFX9edL4RH1wesw8jw0u4a0VUlVV
 BI5Q==
X-Gm-Message-State: ALoCoQkPldE80TbhhZNxcwHclmO8rf/ezrCdtxMEEQxA5JEZqI4oe29TP5JXaUzprN1Bu3NCcGHq
X-Received: by 10.180.9.232 with SMTP id d8mr1026694wib.25.1389980935988;
 Fri, 17 Jan 2014 09:48:55 -0800 (PST)
Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id pk8sm4324888wic.6.2014.01.17.09.48.53
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 17 Jan 2014 09:48:55 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Organization: 6WIND
To: Mats Liljegren <mats.liljegren@enea.com>
Date: Fri, 17 Jan 2014 18:48:52 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <1389274977-53532-1-git-send-email-liljegren.mats2@gmail.com>
 <1389274977-53532-3-git-send-email-liljegren.mats2@gmail.com>
In-Reply-To: <1389274977-53532-3-git-send-email-liljegren.mats2@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201401171848.52284.thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 2/2] pcap: Fill in if_index field for
	rte_eth_dev_info_get()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2014 17:47:41 -0000

what about this title?
"pcap: save if_index of the bound device"

> From: Mats Liljegren <mats.liljegren@enea.com>
> 
> Signed-off-by: Mats Liljegren <mats.liljegren@enea.com>

Could you provide a little explanation, especially about struct args_dict ?

The code seems OK.
Thanks
-- 
Thomas