From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8B2661D7
 for <dev@dpdk.org>; Tue, 24 Apr 2018 21:36:22 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 042F721B77;
 Tue, 24 Apr 2018 15:36:22 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 24 Apr 2018 15:36:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=M+gnq+4rX6sqDokmh8w5/pI2VE
 8fqhsUJdbqLCgV/XQ=; b=kl5wJ9RRFgPBXMGe9kqpb0PoWXuF7gVCQr1oRsDJG0
 TfYyC0bvaTFl9be+V4WANo4EOfgrU9pn0X+rvtTNUKuKhQzVwuxkCs/6iA2g8Ioi
 3fmjaRMUclzGov4qbXXL6KiNu6hVHv+08XKwB3+Wif2ulY6uP7hpp7Ft58yMBftn
 M=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=M+gnq+
 4rX6sqDokmh8w5/pI2VE8fqhsUJdbqLCgV/XQ=; b=MHK/knB+rsMolDG7AOUpI0
 5sGTG+SjRTrErTESXLJcEkapvaPrD3M7MsXJVfb9dFetBovioq0oMC+CQKldqj1G
 u5U57+9OP+o0BV2wiy2bbw4hR9+05JGZiEDjT06L7IbjkszJp0idEcpVD98GwCJ7
 mk5EumtbTFFvj8JXslauKti8Akc0REmn2JPRtDyaHXroo5O5D0DIcgrtZ1FR1qS8
 Itrv8oWF/talJnoxTQ+2kdun+cuTZuUVhRMWUx6CE6c6QNNpCwe2Q7hQv9NfOIZe
 9A7oVuxPzsbV5kz7KfAQ9jmeYNQov6UcFq0LEzFnWGM/8UbvBFOb0nAFh2lma2xg
 ==
X-ME-Sender: <xms:NYffWoPc3doI0kV6a8DI1s__vUf7SGDz0reOfMEayjv1SIh5ahsBtQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id C7597E4924;
 Tue, 24 Apr 2018 15:36:20 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, beilei.xing@intel.com,
 jingjing.wu@intel.com, wenzhuo.lu@intel.com, ferruh.yigit@intel.com,
 declan.doherty@intel.com
Date: Tue, 24 Apr 2018 21:36:19 +0200
Message-ID: <2014014.MPIIikSFdI@xps>
In-Reply-To: <9581683.2joz8NotYG@xps>
References: <20180212045314.171616-1-qi.z.zhang@intel.com>
 <20180408024221.228450-2-qi.z.zhang@intel.com> <9581683.2joz8NotYG@xps>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v6 1/3] ether: support runtime queue setup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2018 19:36:22 -0000

10/04/2018 15:59, Thomas Monjalon:
> > --- a/lib/librte_ether/rte_ethdev.h
> > +++ b/lib/librte_ether/rte_ethdev.h
> > +#define DEV_RUNTIME_RX_QUEUE_SETUP 0x00000001
> > +/**< Deferred setup rx queue */
> > +#define DEV_RUNTIME_TX_QUEUE_SETUP 0x00000002
> > +/**< Deferred setup tx queue */
> 
> Please use RTE_ETH_ prefix.

Qi, you missed this comment.
It must be fixed by a new patch, please.

And the field must mention the related flags prefix.