From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f171.google.com (mail-we0-f171.google.com
 [74.125.82.171]) by dpdk.org (Postfix) with ESMTP id 204096968
 for <dev@dpdk.org>; Tue,  4 Feb 2014 14:06:58 +0100 (CET)
Received: by mail-we0-f171.google.com with SMTP id u56so4135693wes.30
 for <dev@dpdk.org>; Tue, 04 Feb 2014 05:08:18 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc
 :references:in-reply-to:mime-version:content-type
 :content-transfer-encoding:message-id;
 bh=W9w45kcWcVeRYysO6MTa7tDDO0OKkQLytbXMNdNngIk=;
 b=OOSNpwbnG2UlFEPG0gZGgPPBfg6gDC4wiNKV/asYki7ij+slTegnjllVuPJd9tkQx0
 pfECOdX8ewSWdt5d8VMp/11uf+awHJO4Nu7e/U0Qdm7U74afrjbVbZkeu4wBT1ugNiLs
 Di2LcEGeBG3kUY6Nm/gRhAwEAQRWtstsXT2Z31uy03XIETjHZws607JmwqaitQuvhRYv
 OD2COS5h7jBIqFSRdzk83+z40e5ocKIfDizHkwq6O6sh5Gm/vlKoxBPG+Hzp5phY1v4G
 JXIX4jKiJ3A/uEW2835vywLrXf0lNN8JIEIEVXAX8b/Vc0ZUSMWvZr12AWBerIQoaLSD
 lyNg==
X-Gm-Message-State: ALoCoQlm68bQayKxEIoEa6+sxCIqNa3ZMkTAYKWGJ1UBABuG6KfrR33585BAIY/uB5Fhcneo+AMn
X-Received: by 10.180.219.44 with SMTP id pl12mr12771401wic.12.1391519298899; 
 Tue, 04 Feb 2014 05:08:18 -0800 (PST)
Received: from angus.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id d6sm35640066wic.9.2014.02.04.05.08.17
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 04 Feb 2014 05:08:18 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Organization: 6WIND
To: Olivier Matz <olivier.matz@6wind.com>
Date: Tue, 4 Feb 2014 14:08:15 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <1390579157-23890-1-git-send-email-olivier.matz@6wind.com>
 <7F861DC0615E0C47A872E6F3C5FCDDBD0102D11D@BPXM14GP.gisp.nec.co.jp>
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD0102D11D@BPXM14GP.gisp.nec.co.jp>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201402041408.15739.thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [memnic PATCH] pmd: use memory barrier function
	instead of asm volatile
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Feb 2014 13:06:58 -0000

30/01/2014 12:42, Hiroshi Shimamoto:
> > Use the DPDK specific function rte_mb() instead of
> > the GCC statement asm volatile ("" ::: "memory").
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Yes, that's preferred for DPDK, I think.
> Looks okay to me.

Applied, thanks.

-- 
Thomas