From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH 2/2] ixgbe: release software locked semaphores on initialization
Date: Wed, 19 Feb 2014 17:52:11 +0100 [thread overview]
Message-ID: <201402191752.11989.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725808E689E6@IRSMSX105.ger.corp.intel.com>
19/02/2014 13:41, Ananyev, Konstantin:
> Can the patch be reworked to keep changes under librte_pmd_ixgbe/ixgbe
> directory untouched? Those files are derived directly from the BSD driver
> baseline, and any changes will make future merges of newer code more
> challenging. The changes should be limited to files in the
> librte_pmd_ixgbe directory (and ethdev). Thanks
Please, could you send an url to the BSD driver baseline ?
By the way, git is very good at rebasing such patches.
And if the fix is good, it should be applied on the baseline.
Refusing a fix without alternative is not an option.
--
Thomas
next prev parent reply other threads:[~2014-02-19 16:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 11:59 [dpdk-dev] [RFC PATCH 1/2] e1000: " Didier Pallard
2014-02-19 11:59 ` [dpdk-dev] [RFC PATCH 2/2] ixgbe: " Didier Pallard
2014-02-19 12:41 ` Ananyev, Konstantin
2014-02-19 16:52 ` Thomas Monjalon [this message]
2014-02-19 17:51 ` Ananyev, Konstantin
2014-02-21 16:30 ` Ananyev, Konstantin
2014-02-24 14:19 ` didier.pallard
2014-02-24 15:34 ` Ananyev, Konstantin
2014-02-25 0:57 ` Ananyev, Konstantin
2014-02-26 10:52 ` didier.pallard
2014-04-08 13:29 ` [dpdk-dev] [PATCH v3 1/2] " Didier Pallard
2014-04-08 13:29 ` [dpdk-dev] [PATCH v3 2/2] igb: " Didier Pallard
2014-04-09 15:58 ` Ananyev, Konstantin
2014-04-09 16:39 ` Thomas Monjalon
2014-04-09 15:49 ` [dpdk-dev] [PATCH v3 1/2] ixgbe: " Ananyev, Konstantin
2014-04-09 16:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402191752.11989.thomas.monjalon@6wind.com \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).