From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pashupati Kumar <kumarp@brocade.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] RTE CRC hash function
Date: Wed, 26 Feb 2014 10:07:44 +0100 [thread overview]
Message-ID: <201402261007.44344.thomas.monjalon@6wind.com> (raw)
In-Reply-To: <6895EAE0CA8DEE40B92D7CA88BB521F332BA572FC0@HQ1-EXCH02.corp.brocade.com>
10/12/2013 04:17, Pashupati Kumar:
> I am looking at the DPDK implementation for the CRC hash function using
> Intel intrinsics. Shouldn't the order of the arguments being passed to
> _mm_crc32_u32 be reversed ? http://dpdk.org/doc/api/rte__hash__crc_8h.html
>
> For a quick reference, here is the code with Actual and Modified calls.
> static inline uint32_t
> rte_hash_crc_4byte(uint32_t data, uint32_t init_val)
> {
> Actual > return _mm_crc32_u32(data, init_val);
> Modified > return _mm_crc32_u32(init_val, data);
> }
It is now fixed by this commit:
http://dpdk.org/browse/dpdk/commit/?id=65b0663b7f32e4157b71dc14a016215e1bc63157
Thanks for reporting
--
Thomas
prev parent reply other threads:[~2014-02-26 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 3:17 Pashupati Kumar
2014-02-26 9:07 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402261007.44344.thomas.monjalon@6wind.com \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=kumarp@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).