From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 776A469F9
 for <dev@dpdk.org>; Wed, 26 Feb 2014 10:06:21 +0100 (CET)
Received: by mail-wg0-f52.google.com with SMTP id k14so1379526wgh.23
 for <dev@dpdk.org>; Wed, 26 Feb 2014 01:07:47 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:organization:to:subject:date:user-agent:cc
 :references:in-reply-to:mime-version:content-type
 :content-transfer-encoding:message-id;
 bh=5sdmSVunsBX6i1mJaY+wGCS/Exg84WyD/NfgAEUgYBA=;
 b=lrdsd9mTugOlU0gXG7KqkK6Y5igxe7Z9PA+Tm7J5A3TTyTDOMZeV9z0NO+yww+n+4b
 1EnHekBx68g3Ut4Q4isFYHEjuYUNrlg93plFQl2nPESeKcj5SU79A2iVS0yqKyWoJrhw
 WGGHHz/tXDQto8Z9GfMcqQ838tUsKmMX2zGRbFtJW7+S1H3fGigg9RgZu3CrPl9dKpv2
 a9YUbDGs+PAkp88FQ36FPJU0WAcJ4tN27V2T/dGMD9KEFo0TxE3JErLWseq7WycVFBqo
 BR6slTJB6gzkd67FWCTlNwRSOvk9c4jdu5xz7oE0Crz1QcmiArY7vLlJ+n3mlJM/mamm
 9KrA==
X-Gm-Message-State: ALoCoQnltVb4IihyqcFdvR1ymw+TCB05ZFHER2Nhm0fy1mOEKC6qjjKvT61agEZ5a1yhKmNs7D+X
X-Received: by 10.194.62.206 with SMTP id a14mr1467152wjs.26.1393405667155;
 Wed, 26 Feb 2014 01:07:47 -0800 (PST)
Received: from angus.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id jw4sm741554wjc.20.2014.02.26.01.07.45
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 26 Feb 2014 01:07:46 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Organization: 6WIND
To: Pashupati Kumar <kumarp@brocade.com>
Date: Wed, 26 Feb 2014 10:07:44 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <6895EAE0CA8DEE40B92D7CA88BB521F332BA572FC0@HQ1-EXCH02.corp.brocade.com>
In-Reply-To: <6895EAE0CA8DEE40B92D7CA88BB521F332BA572FC0@HQ1-EXCH02.corp.brocade.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201402261007.44344.thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] RTE CRC hash function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Feb 2014 09:06:21 -0000

10/12/2013 04:17, Pashupati Kumar:
> I am looking at the DPDK implementation for  the CRC hash function using
> Intel intrinsics.  Shouldn't the order of the arguments being passed to 
> _mm_crc32_u32 be reversed ? http://dpdk.org/doc/api/rte__hash__crc_8h.html
> 
> For a quick reference, here is the code with Actual and Modified calls.
> static inline uint32_t
> rte_hash_crc_4byte(uint32_t data, uint32_t init_val)
> {
> 	Actual > return _mm_crc32_u32(data, init_val);
> 	Modified > return _mm_crc32_u32(init_val, data);
> }

It is now fixed by this commit:
http://dpdk.org/browse/dpdk/commit/?id=65b0663b7f32e4157b71dc14a016215e1bc63157

Thanks for reporting
-- 
Thomas