From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com
 [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id 341166AB1
 for <dev@dpdk.org>; Fri, 28 Feb 2014 22:38:06 +0100 (CET)
Received: by mail-pa0-f52.google.com with SMTP id fb1so1300099pad.39
 for <dev@dpdk.org>; Fri, 28 Feb 2014 13:39:32 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=FfetkKNoOwmRS5N5ivdTh/Oo1Q4uW4fkBEYaplNVQXQ=;
 b=j0pGwbbvDM5Zmb1fCaKiL2uTzi2Ftkm8DhbrL+xB7paX75bUJCRpM85JsQ/N3R6jWv
 qC4TfRdCy0CVurEeBacOmCd9E3Oo9C1YxrGW7dPUDBwYXpCUICdfoiZXPVaz+pOikCGt
 vXebYEQLEWgVKpqemXiIzKAFnT6ig3u4UpB5W15rovojCmPX30fiukGrHqz7GvL6Brpy
 DUBcYvTRLlMu4dIyS2p/x/wnd8LBZFXCQ8/2QP2xNDwZbjeMORyVUg2KRyDunxW0Uzf8
 BuStC9KLPwDdWcrtN0RBd6kvdWRgW/VWxGbqwOk1DZXA7SccoyzG1omxa6WC9XjIgEa3
 eUUw==
X-Gm-Message-State: ALoCoQkIRn2hvEDi6prJ/++UV3FtLY768nkICN9qS3x5g3vkf3AbXMVtVKkodyJ2IVnZecUNu+90
X-Received: by 10.66.20.10 with SMTP id j10mr6065968pae.11.1393623572625;
 Fri, 28 Feb 2014 13:39:32 -0800 (PST)
Received: from nehalam.linuxnetplumber.net
 (static-50-53-83-51.bvtn.or.frontiernet.net. [50.53.83.51])
 by mx.google.com with ESMTPSA id un5sm21989557pab.3.2014.02.28.13.39.31
 for <multiple recipients>
 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
 Fri, 28 Feb 2014 13:39:32 -0800 (PST)
Date: Fri, 28 Feb 2014 13:39:29 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <20140228133929.03844b24@nehalam.linuxnetplumber.net>
In-Reply-To: <1393608350-4431-3-git-send-email-olivier.matz@6wind.com>
References: <1393608350-4431-1-git-send-email-olivier.matz@6wind.com>
 <1393608350-4431-3-git-send-email-olivier.matz@6wind.com>
X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 02/11] devices-args: introduce rte_devargs in
 eal
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Feb 2014 21:38:06 -0000

On Fri, 28 Feb 2014 18:25:41 +0100
Olivier Matz <olivier.matz@6wind.com> wrote:

> 	switch (devargs->type) {
> +		case RTE_DEVTYPE_WHITELISTED_PCI:
> +		case RTE_DEVTYPE_BLACKLISTED_PCI:
> +			/* try to parse pci identifier */
> +			if (eal_parse_pci_BDF(buf, &devargs->pci.addr) != 0 &&
> +				eal_parse_pci_DomBDF(buf, &devargs->pci.addr) != 0) {
> +				RTE_LOG(ERR, EAL,
> +					"invalid PCI identifier <%s>\n", buf);
> +				free(devargs);
> +				return -1;
> +			}
> +			break;

Minor nit. please align case with switch().
The DPDK in general follows Linux coding style.
In fact, I have run the code through checkpatch to find style issues.