From: Aaro Koskinen <aaro.koskinen@nsn.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: pass CROSS_COMPILE when compiling kernel modules
Date: Fri, 7 Mar 2014 15:32:27 +0200 [thread overview]
Message-ID: <20140307133226.GV15431@ak-desktop.emea.nsn-net.net> (raw)
In-Reply-To: <2031701.DtHZU1GqtL@x220>
Hi,
On Tue, Feb 25, 2014 at 10:55:36PM +0100, Thomas Monjalon wrote:
> 07/02/2014 18:44, Aaro Koskinen :
> > Pass CROSS_COMPILE to the kernel build system when compiling kernel
> > modules. Although we export CC etc. the top level kernel Makefile will
> > override the environment. As a result it will end up using wrong tools
> > if cross-compilation is desired but CROSS_COMPILE is not set.
> >
> > Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>
>
> Could you explain why it's needed ?
> In a basic test, CC=$(CROSS)gcc in rte.vars.mk seems sufficient.
If you compile on 32-bit host to 64-bit target, the build fails with
errors such as:
[...]include/linux/kernfs.h:331:1: note: expected 'const char *' but argument is of type 'const unsigned char *'
kernfs_find_and_get(struct kernfs_node *kn, const char *name)
^
cc1: all warnings being treated as errors
Build with V=1 shows that following appears in the command line
when compiling the kernel modules:
-isystem /usr/lib/gcc/i486-linux-gnu/4.8/include
With the patch this will be corrected to point to my target's sysroot:
-isystem /foo/bar/lib/gcc/x86_64-linux-gnu/4.8.2/include
And the build succeeds without any warnings.
A.
next prev parent reply other threads:[~2014-03-07 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 16:44 Aaro Koskinen
2014-02-25 21:55 ` Thomas Monjalon
2014-03-07 13:32 ` Aaro Koskinen [this message]
2014-04-17 13:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307133226.GV15431@ak-desktop.emea.nsn-net.net \
--to=aaro.koskinen@nsn.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).