From: Stephen Hemminger <stephen@networkplumber.org>
To: "Venkatesan, Venky" <venky.venkatesan@intel.com>
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: [dpdk-dev] [PATCH 4/6] mempool: use GCC push/pop
Date: Fri, 07 Mar 2014 10:13:39 -0800 [thread overview]
Message-ID: <20140307181427.254643901@vyatta.com> (raw)
In-Reply-To: <20140307181335.024904493@vyatta.com>
[-- Attachment #1: mempool-opts.patch --]
[-- Type: text/plain, Size: 936 bytes --]
The include file should not change the GCC compile options for
the whole file being compiled, but only for the one inline function
that needs it. Using the push_options/pop_options fixes this.
Signed-off-by: Stephen Hemminger <shemming@brocade.com>
--- a/lib/librte_mempool/rte_mempool.h 2014-01-23 09:15:55.000000000 -0800
+++ b/lib/librte_mempool/rte_mempool.h 2014-03-06 15:19:56.551238180 -0800
@@ -314,6 +314,7 @@ static inline void __mempool_write_trail
*/
#ifdef RTE_LIBRTE_MEMPOOL_DEBUG
#ifndef __INTEL_COMPILER
+#pragma GCC push_options
#pragma GCC diagnostic ignored "-Wcast-qual"
#endif
static inline void __mempool_check_cookies(const struct rte_mempool *mp,
@@ -380,7 +381,7 @@ static inline void __mempool_check_cooki
}
}
#ifndef __INTEL_COMPILER
-#pragma GCC diagnostic error "-Wcast-qual"
+#pragma GCC pop_options
#endif
#else
#define __mempool_check_cookies(mp, obj_table_const, n, free) do {} while(0)
next prev parent reply other threads:[~2014-03-07 18:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 18:13 [dpdk-dev] [PATCH 0/6] DPDK 1.6.1 fixes Stephen Hemminger
2014-03-07 18:13 ` [dpdk-dev] [PATCH 1/6] rte_mbuf: copy offload flags when doing attach/clone of mbuf Stephen Hemminger
2014-03-24 18:21 ` Thomas Monjalon
2014-03-07 18:13 ` [dpdk-dev] [PATCH 2/6] qos: use rte_zmalloc instead of memzone for allocation Stephen Hemminger
2014-03-24 18:30 ` Thomas Monjalon
2014-03-07 18:13 ` [dpdk-dev] [PATCH 3/6] rte_jhash: make arg to rte_jhash2 const Stephen Hemminger
2014-03-24 18:22 ` Thomas Monjalon
2014-03-07 18:13 ` Stephen Hemminger [this message]
2014-03-24 18:23 ` [dpdk-dev] [PATCH 4/6] mempool: use GCC push/pop Thomas Monjalon
2014-03-07 18:13 ` [dpdk-dev] [PATCH 5/6] xen: dont create dependency on cmdline library Stephen Hemminger
2014-03-24 21:01 ` Thomas Monjalon
2014-03-07 18:13 ` [dpdk-dev] [PATCH 6/6] ivshmem: fix errors identified by hardening Stephen Hemminger
2014-04-17 13:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307181427.254643901@vyatta.com \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
--cc=venky.venkatesan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).