From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pcap: remove test for PCAP_CAN_SEND
Date: Sat, 29 Mar 2014 09:00:27 -0400 [thread overview]
Message-ID: <20140329130027.GA13408@hmsreliant.think-freely.org> (raw)
In-Reply-To: <3857255.iofc7hnFnA@x220>
On Sat, Mar 29, 2014 at 11:34:46AM +0100, Thomas Monjalon wrote:
> Hi Neil,
>
> 28/03/2014 21:32, Neil Horman :
> > The libpcap library has had the ability to send packets since 2004, theres
> > really no need to test for it. Especially in the way dpdk is doing as, as
> > according to the libpcap git tree pcap_sendpacket has never been a #define,
> > and dpdk tests for its existance with an #ifdef. Its easier just to remove
> > the test entirely
> >
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>
> A similar patch is already applied on HEAD:
> http://dpdk.org/browse/dpdk/commit/?id=2a315d698510e7b33
>
My bad, thanks!
Neil
> --
> Thomas
>
prev parent reply other threads:[~2014-03-29 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-29 1:32 Neil Horman
2014-03-29 10:34 ` Thomas Monjalon
2014-03-29 13:00 ` Neil Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140329130027.GA13408@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).