From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 822CCA24B for ; Sun, 13 Apr 2014 18:15:19 +0200 (CEST) Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63) (envelope-from ) id 1WZN3q-0003Ph-3B; Sun, 13 Apr 2014 12:15:14 -0400 Received: from linville-x1.hq.tuxdriver.com (localhost.localdomain [127.0.0.1]) by linville-x1.hq.tuxdriver.com (8.14.8/8.14.6) with ESMTP id s3DG9Ape002399; Sun, 13 Apr 2014 12:09:11 -0400 Received: (from linville@localhost) by linville-x1.hq.tuxdriver.com (8.14.8/8.14.8/Submit) id s3BDkO9N017140; Fri, 11 Apr 2014 09:46:24 -0400 Date: Fri, 11 Apr 2014 09:46:23 -0400 From: "John W. Linville" To: Thomas Monjalon Message-ID: <20140411134623.GB15596@tuxdriver.com> References: <1397140907-17856-1-git-send-email-linville@tuxdriver.com> <5680509.vJ63cQx4Bi@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5680509.vJ63cQx4Bi@xps13> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] rte_pmd_init_all: initialize non-PCI PMDs provided by EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2014 16:15:19 -0000 On Fri, Apr 11, 2014 at 03:23:27PM +0200, Thomas Monjalon wrote: > Hi John, > > 2014-04-10 10:41, John W. Linville: > > These PMDs were being initialized by the EAL layer, but many apps were > > relying on the return value of rte_pmd_init_all to indicate that > > ethernet interfaces were available for use. Move the initialization of > > the non-PCI PMDs to this centralized function to have all of the PMDs > > treated equally. > > > > Signed-off-by: John W. Linville > > We are using constuctors to initialize these drivers. See the patches from > Olivier Matz. > The function rte_pmd_init_all() should be removed. So long as you make DPDK-based apps not die when only using non-PCI (i.e. "virtual") PMDs, I'll be happy... -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.