From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] rte_pmd_init_all: initialize non-PCI PMDs provided by EAL
Date: Sun, 13 Apr 2014 14:22:14 -0400 [thread overview]
Message-ID: <20140413182214.GA10525@hmsreliant.think-freely.org> (raw)
In-Reply-To: <5680509.vJ63cQx4Bi@xps13>
On Fri, Apr 11, 2014 at 03:23:27PM +0200, Thomas Monjalon wrote:
> Hi John,
>
> 2014-04-10 10:41, John W. Linville:
> > These PMDs were being initialized by the EAL layer, but many apps were
> > relying on the return value of rte_pmd_init_all to indicate that
> > ethernet interfaces were available for use. Move the initialization of
> > the non-PCI PMDs to this centralized function to have all of the PMDs
> > treated equally.
> >
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> We are using constuctors to initialize these drivers. See the patches from
> Olivier Matz.
> The function rte_pmd_init_all() should be removed.
>
Actually, from what I see in the git tree and of his patch set, he's only
converted the virtual devices to use constructors with registration functions.
The physical pmd's still use rte_pmd_init_all, so until that changes, this still
seems like a reasonable interim step.
Neil
> So this patch won't be applied.
>
> Your help to continue cleaning this area is welcome.
> --
> Thomas
>
prev parent reply other threads:[~2014-04-13 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 14:41 John W. Linville
2014-04-11 13:23 ` Thomas Monjalon
2014-04-11 13:46 ` John W. Linville
2014-04-13 18:22 ` Neil Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140413182214.GA10525@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).