From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id E655BAFD4
 for <dev@dpdk.org>; Wed, 16 Apr 2014 13:00:26 +0200 (CEST)
Received: from hmsreliant.think-freely.org
 ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1WaNZj-0007lw-2c; Wed, 16 Apr 2014 07:00:26 -0400
Date: Wed, 16 Apr 2014 07:00:18 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20140416110018.GB26829@hmsreliant.think-freely.org>
References: <1397585169-14537-1-git-send-email-nhorman@tuxdriver.com>
 <1397585169-14537-2-git-send-email-nhorman@tuxdriver.com>
 <4354806.0Vn32RcRuD@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4354806.0Vn32RcRuD@xps13>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 01/15] makefiles: Fixed -share command line
	option error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Apr 2014 11:00:27 -0000

On Wed, Apr 16, 2014 at 11:22:35AM +0200, Thomas Monjalon wrote:
> Hi,
> 
> 2014-04-15 14:05, Neil Horman:
> > The shared libraries built with the current makefile set produce static
> > libraries rather than actual shared objects.  This is due to several missing
> > options that are required to correctly build shared objects using ld, as
> > well as a mis-specified -share option (which should be -shared). Switching
> > to the use of CC rather than LD and fixing the -shared option corrects
> > these problems and builds the DSOs correctly.
> > 
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> 
> Thanks for fixing -shared option.
> 
> Regarding switch to CC linking, please have a look at LINK_USING_CC option.
> Maybe you should use it for rte.lib.mk and rte.sharelib.mk.
> 
Yeah, I can do that.  Would you like the whole series reposted, or just the
specific patch?

Neil

> -- 
> Thomas
>