From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 27485AFD6 for ; Wed, 16 Apr 2014 13:02:19 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1WaNbQ-0007mU-SK; Wed, 16 Apr 2014 07:02:18 -0400 Date: Wed, 16 Apr 2014 07:02:04 -0400 From: Neil Horman To: Thomas Monjalon Message-ID: <20140416110204.GC26829@hmsreliant.think-freely.org> References: <1397585169-14537-1-git-send-email-nhorman@tuxdriver.com> <1397585169-14537-3-git-send-email-nhorman@tuxdriver.com> <6240253.CLYuMHWmd2@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6240253.CLYuMHWmd2@xps13> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 02/15] make: include whole archive on static link X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Apr 2014 11:02:19 -0000 On Wed, Apr 16, 2014 at 11:26:48AM +0200, Thomas Monjalon wrote: > 2014-04-15 14:05, Neil Horman: > > This happens automatically on dyanmic linking, but when linking an archive > > we need to to include the whole archive to make sure we call all the > > constructors. Not doing this causes them to be discarded due to the fact > > theres no symbolic reference connecting the pmds to the application. > > > > Signed-off-by: Neil Horman > > This patch conflicts with Olivier's one: > http://dpdk.org/browse/dpdk/commit/?id=20afd76a504155e947 > How does it conflict? I've got it in my dpdk tree here, based off commit 396b69e56a3462ff80537deccebcdecb2771d8ca, which includes Oliviers patch, and mine is applied on top of it cleanly. Neil > -- > Thomas >