From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 45413AFD1
 for <dev@dpdk.org>; Wed, 16 Apr 2014 15:02:21 +0200 (CEST)
Received: from nat-pool-rdu-t.redhat.com ([66.187.233.202] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1WaPTh-0008H7-Sb; Wed, 16 Apr 2014 09:02:20 -0400
Date: Wed, 16 Apr 2014 09:02:04 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20140416130204.GB11887@localhost.localdomain>
References: <1397585169-14537-1-git-send-email-nhorman@tuxdriver.com>
 <6240253.CLYuMHWmd2@xps13>
 <20140416110204.GC26829@hmsreliant.think-freely.org>
 <1915373.2zxdALVbPM@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1915373.2zxdALVbPM@xps13>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 02/15] make: include whole archive on static
	link
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Apr 2014 13:02:21 -0000

On Wed, Apr 16, 2014 at 01:40:19PM +0200, Thomas Monjalon wrote:
> 2014-04-16 07:02, Neil Horman:
> > On Wed, Apr 16, 2014 at 11:26:48AM +0200, Thomas Monjalon wrote:
> > > 2014-04-15 14:05, Neil Horman:
> > > > This happens automatically on dyanmic linking, but when linking an
> > > > archive
> > > > we need to to include the whole archive to make sure we call all the
> > > > constructors. Not doing this causes them to be discarded due to the fact
> > > > theres no symbolic reference connecting the pmds to the application.
> > > > 
> > > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > > 
> > > This patch conflicts with Olivier's one:
> > > 	http://dpdk.org/browse/dpdk/commit/?id=20afd76a504155e947
> > 
> > How does it conflict?  I've got it in my dpdk tree here, based off commit
> > 396b69e56a3462ff80537deccebcdecb2771d8ca, which includes Oliviers patch, and
> > mine is applied on top of it cleanly.
> 
> It's not a git conflict.
> I mean --whole-archive is set twice.
> Maybe that your patch is not needed.
> 
Yeah, I think you're right, its can probably just be dropped.  Let me test quick
and I'll confirm
Neil

> -- 
> Thomas
>