[dpdk-dev] build break on BSD

[dpdk-dev] build break on BSD

[Neil Horman]

Hey-
    I was just trying to do a build on bsd for dpdk and hit this:

== Build lib/librte_eal/bsdapp/eal
  CC eal.o
/root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c: In function ‘eal_parse_args’:
/root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c:654:5: error: implicit
declaration of function ‘eal_dev_whitelist_add_entry’
[-Werror=implicit-function-declaration]
     eal_dev_whitelist_add_entry(optarg);
     ^
/root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c:654:5: error: nested extern
declaration of ‘eal_dev_whitelist_add_entry’ [-Werror=nested-externs]
/root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c:715:3: error: implicit
declaration of function ‘eal_dev_whitelist_exists’
[-Werror=implicit-function-declaration]
   if (eal_dev_whitelist_exists()) {
   ^
/root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c:715:3: error: nested extern
declaration of ‘eal_dev_whitelist_exists’ [-Werror=nested-externs]
/root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c:721:3: error: implicit
declaration of function ‘rte_eal_pci_set_blacklist’
[-Werror=implicit-function-declaration]
   rte_eal_pci_set_blacklist(eal_dev_blacklist, blacklist_index);
   ^
/root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c:721:3: error: nested extern
declaration of ‘rte_eal_pci_set_blacklist’ [-Werror=nested-externs]
/root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c:723:3: error: implicit
declaration of function ‘eal_dev_whitelist_parse’
[-Werror=implicit-function-declaration]
   if (eal_dev_whitelist_exists() && eal_dev_whitelist_parse() < 0) {
   ^
/root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c:723:3: error: nested extern
declaration of ‘eal_dev_whitelist_parse’ [-Werror=nested-externs]

Looks like the recent whitelist/blacklist patches forgot to add the rte_devargs
headers to the BSD build.

Neil

Re: [dpdk-dev] build break on BSD

[Olivier MATZ]

Hi Neil,

On 04/16/2014 09:52 PM, Neil Horman wrote:
>      I was just trying to do a build on bsd for dpdk and hit this:
>
> == Build lib/librte_eal/bsdapp/eal
>    CC eal.o
> /root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c: In function ‘eal_parse_args’:
> /root/git/dpdk/lib/librte_eal/bsdapp/eal/eal.c:654:5: error: implicit
> declaration of function ‘eal_dev_whitelist_add_entry’
> [-Werror=implicit-function-declaration]
>       eal_dev_whitelist_add_entry(optarg);
>       ^
> [...]
>
> Looks like the recent whitelist/blacklist patches forgot to add the rte_devargs
> headers to the BSD build.

Thanks for reporting, I'll have a look ASAP.

Regards,
Olivier