Re: [dpdk-dev] [PATCH 01/15 v2] makefiles: Fixed -share command line option error

[Neil Horman <nhorman@tuxdriver.com>]

On Fri, Apr 18, 2014 at 03:29:01PM +0200, Thomas Monjalon wrote:
> 2014-04-18 09:18, Neil Horman:
> > On Fri, Apr 18, 2014 at 01:23:19PM +0200, Thomas Monjalon wrote:
> > > I think that CPU_LDFLAGS should be prefixed with -Wl, in case of CC
> > > linking. So blindly assigning CC to LD variable seems a bad idea.
> > > Other makefiles have different O_TO_S commands depending of LINK_USING_CC.
> > 
> > I'm not so sure about that.  Or more specifically, I wonder if some more
> > rework isn't needed here.  I say that because, while what you say makes
> > sense in terms of formatting the CPU_FLAGS variable for use with CC, the
> > only current use of CPU_LDFLAGS set -melf_i386, which IIRC is a gcc flag,
> > not meant to be passed to LD.  I can change the makefile to completely
> > rewrite the comand based on LINK_USING_CC, but it seems to me that
> > CPU_LDFLAGS should not be passed in the use of the LD case.
> 
> Right, -melf_i386 shouldn't be a LDFLAG.
> Feel free to fix it.
> By the way, It's cleaner to prepare -Wl prefixing and keep an empty LDFLAGS.
> 
Actually, I looked into this a bit more, turns out -melf_i386 is an LDFLAG.  Its
a bit silly to have it there because its passed automatically from the compiler
to the linker depending on the machine that gcc is building for, or ld does it
natively depending on the input file format.  But perhaps some compiler or
linker version has a bug where that doesn't happen properly.  Either way, it can
be prefixed with a -Wl, so I'm just going to leave it alone
Neil

> -- 
> Thomas
>