From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 076A6591B for ; Tue, 29 Apr 2014 13:00:37 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1Wf5lx-0006Bg-71; Tue, 29 Apr 2014 07:00:39 -0400 Date: Tue, 29 Apr 2014 07:00:24 -0400 From: Neil Horman To: David Marchand Message-ID: <20140429110024.GC11686@hmsreliant.think-freely.org> References: <1398691187-4918-1-git-send-email-david.marchand@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1398691187-4918-1-git-send-email-david.marchand@6wind.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/7] pci cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Apr 2014 11:00:37 -0000 On Mon, Apr 28, 2014 at 03:19:40PM +0200, David Marchand wrote: > Hello all, > > Here is an attempt at having an equal implementation in bsd and linux eal_pci.c. > It results in following changes : > - checks on driver flag in bsd which were missing > - remove virtio-uio workaround in linux eal_pci.c > - remove deprecated RTE_EAL_UNBIND_PORTS option > > Along the way, I discovered two small bugs: a mem leak in linux eal_pci.c and a > fd leak in both bsd and linux eal_pci.c. > Series Acked-by: Neil Horman > > -- > David Marchand > > David Marchand (7): > pci: fix potential mem leak > pci: align bsd implementation on linux > pci: remove virtio-uio workaround > pci: rework interrupt fd init and fix fd leak > pci: pci_switch_module cleanup > pci: move RTE_PCI_DRV_FORCE_UNBIND handling out of #ifdef > pci: remove deprecated RTE_EAL_UNBIND_PORTS option > > lib/librte_eal/bsdapp/eal/eal_pci.c | 105 ++++++------ > lib/librte_eal/linuxapp/eal/eal_pci.c | 282 +++++---------------------------- > lib/librte_pmd_virtio/virtio_ethdev.c | 133 +++++++++++++++- > 3 files changed, 218 insertions(+), 302 deletions(-) > > -- > 1.7.10.4 > >