From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f180.google.com (mail-pd0-f180.google.com [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id 4A88C2E81 for ; Sun, 4 May 2014 22:17:48 +0200 (CEST) Received: by mail-pd0-f180.google.com with SMTP id y10so741808pdj.25 for ; Sun, 04 May 2014 13:17:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=mgy4vzRZs+Oh8Y0gO7sCmDkmJ/fRD11FwrGBt9gDkO4=; b=WRiyvu+pYD+x39kDFT6419z4IkFKxKmjVg1cEap311zjUFr+OYaYZbLp1apcZkpPrm rQ2ZTC3hCG5DY8dRhPyVsIhpPlGEWxyVKK7cQPDI7j04vGTbfrDzs5AskVw2Velg9Sq7 lyhA5Smrs2eOF66/vdIBb8tOHWglFr29z+oN8ZR0qOE0rvhPM4TYmdQyL6iZhyQVWzZt J5DcjZV4gqjZMzfvTZLftYJd7oR/PNi/ZARDUwoHeOIENgmp3poX8Vb5Xu8h3p8eZ9N4 XZBnRVAdQ+Sk8Rx+/uVhfL8HeaL+GdRTYQA/Ckli8alSVQrlgitqT/EUnIql+qgJq/oY dISA== X-Gm-Message-State: ALoCoQkeuKVoaTNAcuAN2qXTPE/kAeMaYNQx1FIUJ/nJFH6B//vee14g7PufPYdqSGH3E59uFN/+ X-Received: by 10.66.142.132 with SMTP id rw4mr63688374pab.6.1399234672884; Sun, 04 May 2014 13:17:52 -0700 (PDT) Received: from nehalam.linuxnetplumber.net (static-50-53-83-51.bvtn.or.frontiernet.net. [50.53.83.51]) by mx.google.com with ESMTPSA id xo9sm52874926pab.18.2014.05.04.13.17.52 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 04 May 2014 13:17:52 -0700 (PDT) Date: Sun, 4 May 2014 13:17:50 -0700 From: Stephen Hemminger To: Neil Horman Message-ID: <20140504131750.45409335@nehalam.linuxnetplumber.net> In-Reply-To: <20140504122053.GA5012@localhost.localdomain> References: <20140502234251.707598579@vyatta.com> <20140502234407.841791092@vyatta.com> <20140504122053.GA5012@localhost.localdomain> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 5/5] add FILE arguement to debug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 May 2014 20:17:49 -0000 On Sun, 4 May 2014 08:20:54 -0400 Neil Horman wrote: > On Fri, May 02, 2014 at 04:42:56PM -0700, Stephen Hemminger wrote: > > The DPDK dump functions are useful for remote debugging of an > > applications. But when application runs as a daemon, stdout > > is typically routed to /dev/null. > > > > Instead change all these functions to take a stdio FILE * handle > > instead. An application can then use open_memstream() to capture > > the output. > > > > Signed-off-by: Stephen Hemminger > > > Why not convert these to rte_log calls? Seems like we already have the > infrastrucutre here, we just need to use it. > Neil > Because it is useful to have remote console like functionatlity, and dumping this to log doesn't work for that.