DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] compilation error with 1.6.0r2
Date: Mon, 12 May 2014 07:33:17 -0400	[thread overview]
Message-ID: <20140512113317.GA21298@hmsreliant.think-freely.org> (raw)
In-Reply-To: <1421183.oxreiJfeoT@xps13>

On Mon, May 12, 2014 at 11:11:56AM +0200, Thomas Monjalon wrote:
> Hi,
> 
> Your email is invalid because of a "proprietary disclaimer".
> 
> Please stop sending such emails.
> 
> 
Except that this totally happens if you set RHEL_RELEASE_CODE to somthing larger
than (6,4).  ethtool_adv_to_mmd_eee_adv_t and its companion functions protected
by that if statement in kcompat.h are never declared in user space, as they are
not included in the uapi/mdio.h header, on in the kernel-specific mdio.h header.
Before you add a clause to include support for 6.5 and later, you need to remove
that if conditional and declare those functions unilaterally for any relase
beyond where it was defined in the kernel.

Neil

> 2014-05-12 14:15, Prashant Upadhyaya:
> > Hi,
> > 
> > I recently picked the 1.6.0r2 from dpdk.org and tried to compile it the
> > usual way and ran into the following compilation error. I am aware I can
> > sidestep these by getting the compiler to treat them as warnings, but these
> > did not use to come with 1.6.0r1 so wanted to report it here. I am using
> > Fedora 18 to compile this version of DPDK.
> > 
> > Regards
> > -Prashant
> > 
> > 
> > [root@localhost ~]# cd dpdk-1.6.0r2/
> > [root@localhost dpdk-1.6.0r2]# make install T=x86_64-default-linuxapp-gcc
> > ================== Installing x86_64-default-linuxapp-gcc
> > == Build scripts
> > == Build scripts/testhost
> > == Build lib
> > == Build lib/librte_eal
> > == Build lib/librte_eal/common
> > == Build lib/librte_eal/linuxapp
> > == Build lib/librte_eal/linuxapp/igb_uio
> >   Building modules, stage 2.
> >   MODPOST 1 modules
> > == Build lib/librte_eal/linuxapp/eal
> > == Build lib/librte_eal/linuxapp/kni
> >   CC [M] 
> > /root/dpdk-1.6.0r2/x86_64-default-linuxapp-gcc/build/lib/librte_eal/linuxap
> > p/kni/igb_ethtool.o
> > /root/dpdk-1.6.0r2/x86_64-default-linuxapp-gcc/build/lib/librte_eal/linuxap
> > p/kni/igb_ethtool.c: In function 'igb_get_eee':
> > /root/dpdk-1.6.0r2/x86_64-default-linuxapp-gcc/build/lib/librte_eal/linuxap
> > p/kni/igb_ethtool.c:2441:4: error: implicit declaration of function
> > 'mmd_eee_adv_to_ethtool_adv_t' [-Werror=implicit-function-declaration]
> > /root/dpdk-1.6.0r2/x86_64-default-linuxapp-gcc/build/lib/librte_eal/linuxap
> > p/kni/igb_ethtool.c: In function 'igb_set_eee':
> > /root/dpdk-1.6.0r2/x86_64-default-linuxapp-gcc/build/lib/librte_eal/linuxap
> > p/kni/igb_ethtool.c:2551:2: error: implicit declaration of function
> > 'ethtool_adv_to_mmd_eee_adv_t' [-Werror=implicit-function-declaration] cc1:
> > all warnings being treated as errors
> > make[10]: ***
> > [/root/dpdk-1.6.0r2/x86_64-default-linuxapp-gcc/build/lib/librte_eal/linuxa
> > pp/kni/igb_ethtool.o] Error 1 make[9]: ***
> > [_module_/root/dpdk-1.6.0r2/x86_64-default-linuxapp-gcc/build/lib/librte_ea
> > l/linuxapp/kni] Error 2 make[8]: *** [sub-make] Error 2
> > make[7]: *** [rte_kni.ko] Error 2
> > make[6]: *** [kni] Error 2
> > make[5]: *** [linuxapp] Error 2
> > make[4]: *** [librte_eal] Error 2
> > make[3]: *** [lib] Error 2
> > make[2]: *** [all] Error 2
> > make[1]: *** [x86_64-default-linuxapp-gcc_install] Error 2
> > make: *** [install] Error 2
> > [root@localhost dpdk-1.6.0r2]#
> > 
> > 
> > 
> > "DISCLAIMER: This message is proprietary to Aricent and is intended solely
> > for the use of the individual to whom it is addressed. It may contain
> > privileged or confidential information and should not be circulated or used
> > for any purpose other than for what it is intended. If you have received
> > this message in error, please notify the originator immediately. If you are
> > not the intended recipient, you are notified that you are strictly
> > prohibited from using, copying, altering, or disclosing the contents of
> > this message. Aricent accepts no responsibility for loss or damage arising
> > from the use of the information transmitted by this email including damage
> > from virus."
> 
> 

  reply	other threads:[~2014-05-12 11:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-12  8:45 Prashant Upadhyaya
2014-05-12  9:11 ` Thomas Monjalon
2014-05-12 11:33   ` Neil Horman [this message]
2014-05-15 14:44 Prashant Upadhyaya
2014-05-22 14:31 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140512113317.GA21298@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).