Re: [dpdk-dev] [PATCH 0/3] ring: provide rte_ring_as_ethdev API

[Neil Horman <nhorman@tuxdriver.com>]

On Fri, May 16, 2014 at 07:15:11PM +0100, Bruce Richardson wrote:
> This patch set aims to provide a shorter simpler alternative the public API functions for using rings as ethdevs provided by the librte_pmd_ring library. This alternative just provides simple RX and TX burst functions and a conversion API, without any of the complexities present in the pmd_ring version. This replacement should allow the public APIs in the pmd_ring library to be deprecated in the future.
> 
> Bruce Richardson (3):
>   ethdev: Remove ethdev.h dependency on mbuf +  mempool
>   ring: add support for converting a ring to ethdev
>   ring: autotest for using ring as ethdev
> 
>  app/test-pmd/cmdline.c                  |  1 +
>  app/test/test_pmd_ring.c                |  1 +
>  app/test/test_ring.c                    | 25 ++++++++++++++++++++
>  lib/librte_ether/rte_ethdev.h           |  4 +++-
>  lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c |  1 +
>  lib/librte_ring/Makefile                |  1 +
>  lib/librte_ring/rte_ring.c              | 42 +++++++++++++++++++++++++++++++++
>  lib/librte_ring/rte_ring.h              | 11 +++++++++
>  8 files changed, 85 insertions(+), 1 deletion(-)
> 
> -- 
> 1.9.0
> 
> 
NAK, I don't think this makes sense.  If you want to encapsulate a ring pair as
an ethdev, then write a pmd that does so.  That will give you a standardized
ethdev that you can create using the existing --vdev librte_eal command line
options without having to widen your API surface, or having to write
applications that specifically know about the fact that your ethdev is composed
of rings under the covers.

Neil