From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 0AEC6231C for ; Tue, 20 May 2014 19:14:23 +0200 (CEST) Received: from hmsreliant.think-freely.org ([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63) (envelope-from ) id 1WmncN-0003Lz-Db; Tue, 20 May 2014 13:14:31 -0400 Date: Tue, 20 May 2014 13:14:22 -0400 From: Neil Horman To: "Richardson, Bruce" Message-ID: <20140520171422.GE6648@hmsreliant.think-freely.org> References: <1400580057-30155-1-git-send-email-bruce.richardson@intel.com> <20140520103845.GA6648@hmsreliant.think-freely.org> <59AF69C657FD0841A61C55336867B5B01AA1BCF2@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59AF69C657FD0841A61C55336867B5B01AA1BCF2@IRSMSX103.ger.corp.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) X-Spam-Status: No Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/4] New library: rte_distributor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 May 2014 17:14:23 -0000 On Tue, May 20, 2014 at 11:02:15AM +0000, Richardson, Bruce wrote: > > -----Original Message----- > > From: Neil Horman [mailto:nhorman@tuxdriver.com] > > Sent: Tuesday, May 20, 2014 11:39 AM > > To: Richardson, Bruce > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 0/4] New library: rte_distributor > > > > > > > This sounds an awful lot like the team and bonding drivers. Why implement this > > as a separate application accessible api, rather than a stacked PMD? If you do > > the latter then existing applications could concievably change their > > configurations to use this technology and gain the benefit of load distribution > > without having to alter the application to use a new api. > > > > I'm not sure I see the similarity with the bonded driver, which merges multiple ports into a single logical port, i.e. you pull packets from a single source which is actually pull packets from possibly multiple sources behind the scenes, whereas this takes packets from an unknown source and distributes them among a set of workers a single packet at a time. (While handling single packets is slower than handling packet bursts, it is something that is sometimes needed to support existing code which may not be written to work with packet bursts.) > Ah, my bad, I was looking at the API as a way of multiplexing locally generated data to multiple workers for transmission over multiple network interfaces, not to demultiplex received data to multiple workers. That makes more sense. Sorry for the noise. I've got a few more comments inline with the rest of your patches. Neil