From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f180.google.com (mail-pd0-f180.google.com [209.85.192.180]) by dpdk.org (Postfix) with ESMTP id AE2063F9 for ; Thu, 5 Jun 2014 17:22:37 +0200 (CEST) Received: by mail-pd0-f180.google.com with SMTP id y13so1220264pdi.25 for ; Thu, 05 Jun 2014 08:22:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=miuE8EhF0lBnEjU7nkiC/+58xXRK6q8Sfy/bXWqOTEw=; b=F+0O/cwXVX3aHWwHFubQ9TACsxfHIF3ZUgCc8d+lEXxSl+A2dlUR3VROpKrjh0+59Z BeBotpqdC3GAmZmFWGPaR8MUdIR3xVKHNyNk2DpcVC50HJVzE1AwfKeVwolyic8091jj 1blg0sR7DNTR1Rr8mK31p+nn7hZBY5/jzluq3CAaUrA3JFNnH604D1NBG12+qMLQOLyr zSlzRxfBDb6FaJRqqx/Z3+yAcvnJ7yY6HsplhKxr+7H3hPDnVDExj6rWVinHs99JeAKL 4Jxef9nRaf7IiR2rjWd3U9i2aDcTdQZeQmXNU6lp1efsjGDatQUgDFEevX3VV9qRUIu/ ehDA== X-Gm-Message-State: ALoCoQk8bXVB1ZCxueAGIl/PwhABA2+QOEb7t7iN5/2vfHwiFC5L8okkprya9o5zp+0cd0cL3RNt X-Received: by 10.68.220.103 with SMTP id pv7mr78418544pbc.17.1401981770201; Thu, 05 Jun 2014 08:22:50 -0700 (PDT) Received: from nehalam.linuxnetplumber.net (static-50-53-83-51.bvtn.or.frontiernet.net. [50.53.83.51]) by mx.google.com with ESMTPSA id qq5sm24107551pbb.24.2014.06.05.08.22.49 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 05 Jun 2014 08:22:49 -0700 (PDT) Date: Thu, 5 Jun 2014 08:22:47 -0700 From: Stephen Hemminger To: Alan Carew Message-ID: <20140605082247.2e17c529@nehalam.linuxnetplumber.net> In-Reply-To: <1401979159-14576-1-git-send-email-alan.carew@intel.com> References: <1401979159-14576-1-git-send-email-alan.carew@intel.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/4] librte_pmd_virtio :Fix: virtio_pci.h non-existent virtio feature bit-flag tested X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jun 2014 15:22:38 -0000 On Thu, 5 Jun 2014 15:39:15 +0100 Alan Carew wrote: > This series addresses an issue with librte_pmd_virtio where the offset to the > virtio device specific header may be incorrect depending on whether MSI-X has > been enabled or not. > > If MSI-X is configured the device specific header is placed at byte offset 24 > relative to the IO base address. > If MSI-X is not configured the device specific header is placed at > byte offset 20. > > The following macro defined in virtio_pci.h is used to test the > presence of the MSI-X header and determine the correct offset: > #define VIRTIO_PCI_CONFIG(hw) (((hw)->guest_features & VIRTIO_PCI_FLAG_MSIX) ? 24 : 20) > > However, VIRTIO_PCI_FLAG_MSIX is not a guest_feature nor is it part of the > Virtio Specification and resolves to the VIRTIO_NET_F_MAC feature as both > are #defined as 0x20. > > VIRTIO_PCI_FLAG_MSIX or similar flag should instead be set by the kernel > driver allocating resources and passed to user space for testing. > i.e. > #define VIRTIO_PCI_CONFIG(hw) (((hw)->intr_mode & IGBUIO_MSIX_INTR_MODE) ? 24 : 20) > > To enable this testing of interrupt mode, this series allows for the kernel > driver(igb_uio) to place the configured interrupt mode into a sysfs entry. > sysfs is then parsed by eal_pci to determine the configured mode, which > allows all user space devices to correctly determine the interrupt mode, > including virtio_ethdev. > > This series should be applied prior to Anatoly Burakov's > [VFIO] Add VFIO support to DPDK series > > Alan Carew (4): > igb_uio: Add interrupt_mode sysfs entry for igb_uio devices > eal_pci: Add interrupt mode to rte_pci_device and parsing to eal_pci > FreeBSD: Adds the equivalent interrupt mode setting and parsing > virtio: Fixes the VIRTIO_PCI_CONFIG macro to use the correct offset > to the Virtio header > > lib/librte_eal/bsdapp/eal/eal_pci.c | 44 ++++++++++ > lib/librte_eal/bsdapp/nic_uio/nic_uio.c | 14 +++ > lib/librte_eal/common/Makefile | 1 + > lib/librte_eal/common/include/rte_pci.h | 2 + > .../common/include/rte_pci_dev_feature_defs.h | 85 ++++++++++++++++++++ > .../common/include/rte_pci_dev_features.h | 70 ++++++++++++++++ > lib/librte_eal/linuxapp/eal/eal_pci.c | 78 ++++++++++++++++++ > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 48 +++++++++--- > lib/librte_pmd_virtio/virtio_ethdev.c | 1 + > lib/librte_pmd_virtio/virtio_pci.h | 4 +- > 10 files changed, 336 insertions(+), 11 deletions(-) > create mode 100755 lib/librte_eal/common/include/rte_pci_dev_feature_defs.h > create mode 100755 lib/librte_eal/common/include/rte_pci_dev_features.h > I took the simpler approach. Since DPDK devices doesn't really need the multiple vectors of MSI-X at all, I just converted igb_uio to use MSI instead.