From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pb0-f48.google.com (mail-pb0-f48.google.com [209.85.160.48]) by dpdk.org (Postfix) with ESMTP id 4B7C83F9 for ; Sat, 7 Jun 2014 01:50:50 +0200 (CEST) Received: by mail-pb0-f48.google.com with SMTP id rr13so3086603pbb.35 for ; Fri, 06 Jun 2014 16:51:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:user-agent:date:from:to:cc:subject :references:mime-version:content-type:content-disposition; bh=IqpNdAhiVlHFEOxPDIckcZk2KV1aDRZ7IrUzBH9f1js=; b=lXFZ1VGjhht0oVj+PWTDNT29UNVwAaXk09jQGq4O/xX2kStwoNUOvOZ8Yp4ecI2nVo Ez4Z5TU0hQdS3ViAXHF2iE+D/6BwvuO6Ivw1LoYjKdXM8QBJ5IEQ4zs9O5XouzAfV46H t5DvoVqOxDNOYmarKJOZML/S0BhIyVJGEvzvrbPegWJo8kyiOfOKxh2nYlG6l316qf0l PEcN4vvOzMI0+ZQzcDpxZhwKiXrDxUfcu8BtNrvmA46K+s8cXrW5iK7pLl+Bn2wcOcI/ 2qW85nkoIg3h/+esHw2ypKMS0Ksda6WVWC5EDUhWNH41VgiqSzCzTBckyHtFva0HcEcQ zwlw== X-Gm-Message-State: ALoCoQkEWhsEnjMogyasFVbG6t/NDXE4HnEVawszlPsiW1LqE1rjjudABASGA3OzuhYN6pn+YV9D X-Received: by 10.68.200.10 with SMTP id jo10mr5973256pbc.143.1402098663575; Fri, 06 Jun 2014 16:51:03 -0700 (PDT) Received: from localhost (static-50-53-83-51.bvtn.or.frontiernet.net. [50.53.83.51]) by mx.google.com with ESMTPSA id ei4sm40892717pbb.42.2014.06.06.16.51.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Jun 2014 16:51:02 -0700 (PDT) Message-Id: <20140606235102.075783317@networkplumber.org> User-Agent: quilt/0.63-1 Date: Fri, 06 Jun 2014 16:50:29 -0700 From: Stephen Hemminger To: Alan Carew References: <20140606235028.189345212@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Disposition: inline; filename=igb_uio-msg.patch Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH v2 01/10] igb_uio: use kernel standard log message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jun 2014 23:50:50 -0000 Use Linux kernel standard coding conventions for console messages. Bare use of printk() is not desirable and is reported as a style problem by checkpatch. Instead use pr_info() and dev_info() to print out log messages where appropriate. Signed-off-by: Stephen Hemminger --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c @@ -22,6 +22,8 @@ * Intel Corporation */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + #include #include #include @@ -314,7 +316,7 @@ pci_unlock(pdev); spin_unlock: spin_unlock_irqrestore(&udev->lock, flags); - printk(KERN_INFO "irq 0x%x %s\n", irq, (ret == IRQ_HANDLED) ? "handled" : "not handled"); + pr_info("irq 0x%x %s\n", irq, (ret == IRQ_HANDLED) ? "handled" : "not handled"); return ret; } @@ -477,7 +479,7 @@ * memory */ if (pci_enable_device(dev)) { - printk(KERN_ERR "Cannot enable PCI device\n"); + dev_err(&dev->dev, "Cannot enable PCI device\n"); goto fail_free; } @@ -486,7 +488,7 @@ * module */ if (pci_request_regions(dev, "igb_uio")) { - printk(KERN_ERR "Cannot request regions\n"); + dev_err(&dev->dev, "Cannot request regions\n"); goto fail_disable; } @@ -499,10 +501,10 @@ /* set 64-bit DMA mask */ if (pci_set_dma_mask(dev, DMA_BIT_MASK(64))) { - printk(KERN_ERR "Cannot set DMA mask\n"); + dev_err(&dev->dev, "Cannot set DMA mask\n"); goto fail_release_iomem; } else if (pci_set_consistent_dma_mask(dev, DMA_BIT_MASK(64))) { - printk(KERN_ERR "Cannot set consistent DMA mask\n"); + dev_err(&dev->dev, "Cannot set consistent DMA mask\n"); goto fail_release_iomem; } @@ -533,7 +535,7 @@ } else { pci_disable_msix(udev->pdev); - printk(KERN_INFO "fail to enable pci msix, or not enough msix entries\n"); + pr_info("fail to enable pci msix, or not enough msix entries\n"); } } switch (udev->mode) { @@ -585,7 +587,7 @@ struct uio_info *info = pci_get_drvdata(dev); if (info->priv == NULL) { - printk(KERN_DEBUG "Not igbuio device\n"); + pr_notice("Not igbuio device\n"); return; } @@ -605,18 +607,18 @@ igbuio_config_intr_mode(char *intr_str) { if (!intr_str) { - printk(KERN_INFO "Use MSIX interrupt by default\n"); + pr_info("Use MSIX interrupt by default\n"); return 0; } if (!strcmp(intr_str, "msix")) { igbuio_intr_mode_preferred = IGBUIO_MSIX_INTR_MODE; - printk(KERN_INFO "Use MSIX interrupt\n"); + pr_info("Use MSIX interrupt\n"); } else if (!strcmp(intr_str, "legacy")) { igbuio_intr_mode_preferred = IGBUIO_LEGACY_INTR_MODE; - printk(KERN_INFO "Use legacy interrupt\n"); + pr_info("Use legacy interrupt\n"); } else { - printk(KERN_INFO "Error: bad parameter - %s\n", intr_str); + pr_info("Error: bad parameter - %s\n", intr_str); return -EINVAL; }