From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pb0-f43.google.com (mail-pb0-f43.google.com
 [209.85.160.43]) by dpdk.org (Postfix) with ESMTP id 3C79EADBE
 for <dev@dpdk.org>; Sat,  7 Jun 2014 01:51:00 +0200 (CEST)
Received: by mail-pb0-f43.google.com with SMTP id up15so3095387pbc.2
 for <dev@dpdk.org>; Fri, 06 Jun 2014 16:51:13 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:user-agent:date:from:to:cc:subject
 :references:mime-version:content-type:content-disposition;
 bh=jruu3GhIry4qFUtQTbTSiJfbiQk2Dxak2K6b2JP2Crk=;
 b=U9vwyBcDSneB8hdrChrrRcs58Xnoa57KwutlBuWNVDBGoe80aaYhPhJgJFrjkEOIKq
 u2HYHugJbUkofUZItAeIJml34UpYr6zRIeZ066PygzvP4KgWdqPjk++t9cKPc276vFAL
 VMxcU44RRgT480/OeSbXdfK62GURR53PiZX75CFU3uuKQjxXBXoH204qS/3Bc0EOf3vC
 UpBSTxPWpLcm0sP/tlVy8BbxGxgmoO9yv7J8sTTr4+0ISzz2ULozOLm8NjUGe80zg/+8
 I7GB7r+kHeKVz98UEgKYKBO9LQMCZzwAWoG2EVbx3+cOdwlcaxSRSzHVF+pQYS0Op4o0
 6atA==
X-Gm-Message-State: ALoCoQmwUtt1NqnGJKkb6kh0mv4vx5ukWmhCoc1WhuvrriuC5jvasRD0pcpMU9JQ5KVKDWLnxDZ1
X-Received: by 10.68.242.135 with SMTP id wq7mr5973941pbc.147.1402098673546;
 Fri, 06 Jun 2014 16:51:13 -0700 (PDT)
Received: from localhost (static-50-53-83-51.bvtn.or.frontiernet.net.
 [50.53.83.51])
 by mx.google.com with ESMTPSA id ei4sm40893820pbb.42.2014.06.06.16.51.12
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 06 Jun 2014 16:51:12 -0700 (PDT)
Message-Id: <20140606235111.964007763@networkplumber.org>
User-Agent: quilt/0.63-1
Date: Fri, 06 Jun 2014 16:50:35 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Alan Carew <alan.carew@intel.com>
References: <20140606235028.189345212@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Disposition: inline; filename=igb_uio-mode-param-ro.patch
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 07/10] igb_uio: make irq mode param read-only
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jun 2014 23:51:01 -0000

The module parameter is read-only since changing mode after loading
isn't going to work.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
@@ -647,7 +647,7 @@
 module_init(igbuio_pci_init_module);
 module_exit(igbuio_pci_exit_module);
 
-module_param(intr_mode, charp, S_IRUGO | S_IWUSR);
+module_param(intr_mode, charp, S_IRUGO);
 MODULE_PARM_DESC(intr_mode,
 "igb_uio interrupt mode (default=msix):\n"
 "    msix       Use MSIX interrupt\n"