From: Stephen Hemminger <stephen@networkplumber.org>
To: Alan Carew <alan.carew@intel.com>
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 10/10] igbuio: use mode string for module param
Date: Fri, 06 Jun 2014 16:50:38 -0700 [thread overview]
Message-ID: <20140606235116.841557340@networkplumber.org> (raw)
In-Reply-To: <20140606235028.189345212@networkplumber.org>
[-- Attachment #1: igb_uio-mode-param-table.patch --]
[-- Type: text/plain, Size: 1395 bytes --]
Since we now have a list of interrupt modes for sysfs,
use that to match module param values. This also allows msi
to be selected as a preferred mode.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
@@ -605,21 +605,24 @@
static int
igbuio_config_intr_mode(char *intr_str)
{
+ unsigned int i;
+
if (!intr_str) {
pr_info("Use MSIX interrupt by default\n");
return 0;
}
- if (!strcmp(intr_str, "msix")) {
- igbuio_intr_mode_preferred = IGBUIO_MSIX_INTR_MODE;
- pr_info("Use MSIX interrupt\n");
- } else if (!strcmp(intr_str, "legacy")) {
- igbuio_intr_mode_preferred = IGBUIO_LEGACY_INTR_MODE;
- pr_info("Use legacy interrupt\n");
- } else {
- pr_info("Error: bad parameter - %s\n", intr_str);
- return -EINVAL;
- }
+ for (i = 0; i < ARRAY_SIZE(igbuio_intr_modes); i++) {
+ const char *mode = igbuio_intr_modes[i];
+ if (!strcmp(intr_str, mode)) {
+ pr_info("Use %s interrupt mode\n", mode);
+ igbuio_intr_mode_preferred = i;
+ return 0;
+ }
+ }
+
+ pr_warn("bad interrupt mode parameter %s\n", intr_str);
+ return -EINVAL;
return 0;
}
@@ -656,6 +659,7 @@
MODULE_PARM_DESC(intr_mode,
"igb_uio interrupt mode (default=msix):\n"
" msix Use MSIX interrupt\n"
+" msi Use MSI interrupt\n"
" legacy Use Legacy interrupt\n"
"\n");
next prev parent reply other threads:[~2014-06-06 23:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 23:50 [dpdk-dev] [PATCH v2 00/10] igb_uio patches Stephen Hemminger
2014-06-06 23:50 ` [dpdk-dev] [PATCH v2 01/10] igb_uio: use kernel standard log message Stephen Hemminger
2014-06-06 23:50 ` [dpdk-dev] [PATCH v2 02/10] igb_uio: use standard uio naming Stephen Hemminger
2014-06-06 23:50 ` [dpdk-dev] [PATCH v2 03/10] igb_uio: fix checkpatch warnings Stephen Hemminger
2014-06-06 23:50 ` [dpdk-dev] [PATCH v2 04/10] igb_uio: dont wrap pci_num_vf function needlessly Stephen Hemminger
2014-06-06 23:50 ` [dpdk-dev] [PATCH v2 05/10] Subjec: igb_uio: msix cleanups Stephen Hemminger
2014-07-18 11:05 ` Thomas Monjalon
2014-06-06 23:50 ` [dpdk-dev] [PATCH v2 06/10] igb_uio: propogate error numbers in probe code Stephen Hemminger
2014-06-06 23:50 ` [dpdk-dev] [PATCH v2 07/10] igb_uio: make irq mode param read-only Stephen Hemminger
2014-06-06 23:50 ` [dpdk-dev] [PATCH v2 08/10] igb_uio: fix IRQ mode handling Stephen Hemminger
2014-07-18 11:49 ` Thomas Monjalon
2014-07-18 12:41 ` Thomas Monjalon
2014-06-06 23:50 ` [dpdk-dev] [PATCH v2 09/10] igbuio: show irq mode in sysfs Stephen Hemminger
2014-06-08 15:37 ` Neil Horman
2014-06-11 18:27 ` Carew, Alan
2014-06-11 20:08 ` Stephen Hemminger
2014-06-16 8:03 ` Carew, Alan
2014-06-13 0:28 ` Neil Horman
2014-06-06 23:50 ` Stephen Hemminger [this message]
2014-06-13 16:14 ` [dpdk-dev] [PATCH v2 00/10] igb_uio patches Thomas Monjalon
2014-06-13 17:24 ` Stephen Hemminger
2014-06-13 17:51 ` [dpdk-dev] [PATCH] igb_uio: cap max VFs at 7 to reserve one for PF Chris Wright
2014-06-13 18:02 ` Richardson, Bruce
2014-06-13 18:14 ` Chris Wright
2014-06-13 19:22 ` Richardson, Bruce
2014-06-13 19:48 ` Chris Wright
2014-06-16 14:13 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606235116.841557340@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=alan.carew@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).