From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f173.google.com (mail-pd0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 5079158D7 for ; Fri, 13 Jun 2014 03:39:49 +0200 (CEST) Received: by mail-pd0-f173.google.com with SMTP id r10so1556881pdi.32 for ; Thu, 12 Jun 2014 18:40:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-type:content-transfer-encoding; bh=J6TuOMpqxUhPLA9kDkmfNNHf6nRN8tbtMKRWNFqGnIQ=; b=BQ0/ttbRztOOSgySVRPhEt7A4i+ukrrhPWatLvxJua5tgnGrJrQxG2JzYAhSAq4Etx ATQMFMnhkhIq4kuJoxjpwRUDWaMDtGoMDZvcYVcIx63ekBfvEGgMgSN/jIE9Y2HudO5h VyeEIyG6PC8TghHfMv2xKy25amnrzbsJ7moNyQHlsAg34pnL/O1ZpUXHKHxB9LjQGDN6 2x/iyuciAJqSE9DoHSlh3a4xnHN6M9c/nYYM3Urz2+r/I4ILq9me7uUqw8BaA0hZ0yX8 M/b1CkJtOx/vzX/M/UR0Afqpol2+JzfLOyN/s8DF4SmX6RnfyBWUwzIlZZGv+ivfOC7o IZSQ== X-Gm-Message-State: ALoCoQmJ+qYMmkxobxpNBjLj2d229c4R9Oby/3akV/c7xeSyfuyJeX/ZDT4i9XWZXVMWUV0BE5IS X-Received: by 10.66.122.101 with SMTP id lr5mr25452964pab.130.1402623604029; Thu, 12 Jun 2014 18:40:04 -0700 (PDT) Received: from nehalam.linuxnetplumber.net (static-50-53-83-51.bvtn.or.frontiernet.net. [50.53.83.51]) by mx.google.com with ESMTPSA id iz2sm408030pbb.95.2014.06.12.18.40.03 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 12 Jun 2014 18:40:03 -0700 (PDT) Date: Thu, 12 Jun 2014 18:36:56 -0700 From: Stephen Hemminger To: dev@dpdk.org Message-ID: <20140612183656.08516008@nehalam.linuxnetplumber.net> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [dpdk-dev] [PATCH 1/5] vmxnet3: fix all multicast vs promiscious X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2014 01:39:49 -0000 The driver was incorrectly enabling/disabling promiscious mode when it should have be setting/clearing all multicast mode. Signed-off-by: Stephen Hemminger --- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c 2014-06-10 15:30:24.000097039 -0700 +++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c 2014-06-10 15:30:23.996097012 -0700 @@ -708,7 +708,7 @@ static void vmxnet3_dev_allmulticast_enable(struct rte_eth_dev *dev) { struct vmxnet3_hw *hw = VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private); - vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_PROMISC, 1); + vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_ALL_MULTI, 1); } /* Allmulticast supported only if Vmxnet3_DriverShared is initialized in adapter */ @@ -716,7 +716,7 @@ static void vmxnet3_dev_allmulticast_disable(struct rte_eth_dev *dev) { struct vmxnet3_hw *hw = VMXNET3_DEV_PRIVATE_TO_HW(dev->data->dev_private); - vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_PROMISC, 0); + vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_ALL_MULTI, 0); } #if PROCESS_SYS_EVENTS == 1