From: Neil Horman <nhorman@tuxdriver.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vfio: open VFIO container at startup rather than during init
Date: Wed, 18 Jun 2014 07:00:18 -0400 [thread overview]
Message-ID: <20140618110018.GA7587@hmsreliant.think-freely.org> (raw)
In-Reply-To: <C6ECDF3AB251BE4894318F4E451236976CC9CCAC@IRSMSX101.ger.corp.intel.com>
On Wed, Jun 18, 2014 at 10:26:08AM +0000, Burakov, Anatoly wrote:
> Hi Cristian,
>
> > I would suggest we add a log message explaining which mechanism is loaded
> > (igb_uio/vfio) and why (e.g. tried vfio first but container could not be
> > opened, so falling back to igb_uio, etc).
>
> This already happens.
>
> If the container could not be loaded for whatever reason, the log message is displayed (it did before, but the previous code didn't account for situations such as Bruce was having, hence the patch). If VFIO is loaded and enabled, all drivers will then report either being bound or skipped (e.g. "not bound to VFIO, skipping").
I think what Thomas wants is for you to resend the patch with a proper changelog
entry added to it, so the commit has an explination of what was changed and, for
posterity.
Neil
>
> Best regards,
> Anatoly Burakov
> DPDK SW Engineer
>
>
>
>
next prev parent reply other threads:[~2014-06-18 11:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 9:12 Anatoly Burakov
2014-06-17 16:50 ` Richardson, Bruce
2014-06-17 16:55 ` Thomas Monjalon
2014-06-18 8:57 ` Burakov, Anatoly
2014-06-18 10:08 ` Dumitrescu, Cristian
2014-06-18 10:26 ` Burakov, Anatoly
2014-06-18 11:00 ` Neil Horman [this message]
2014-06-18 11:02 ` Burakov, Anatoly
2014-06-18 11:07 ` Neil Horman
2014-06-18 13:07 ` [dpdk-dev] [PATCH v2 0/2] Fix issues with VFIO Anatoly Burakov
2014-06-18 13:07 ` [dpdk-dev] [PATCH v2 1/2] vfio: open VFIO container at startup rather than during init Anatoly Burakov
2014-06-18 13:07 ` [dpdk-dev] [PATCH v2 2/2] vfio: more verbose error messages Anatoly Burakov
2014-06-18 13:44 ` [dpdk-dev] [PATCH v2 0/2] Fix issues with VFIO Neil Horman
2014-06-18 15:07 ` [dpdk-dev] [PATCH v3 " Anatoly Burakov
2014-06-18 15:07 ` [dpdk-dev] [PATCH v3 1/2] vfio: open VFIO container at startup rather than during init Anatoly Burakov
2014-06-18 15:07 ` [dpdk-dev] [PATCH v3 2/2] vfio: more verbose error messages Anatoly Burakov
2014-06-18 17:55 ` [dpdk-dev] [PATCH v3 0/2] Fix issues with VFIO Richardson, Bruce
2014-06-18 23:09 ` Thomas Monjalon
2014-06-18 18:51 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618110018.GA7587@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).