From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com
 [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id D1BBB30D
 for <dev@dpdk.org>; Sat, 21 Jun 2014 01:57:52 +0200 (CEST)
Received: by mail-pa0-f53.google.com with SMTP id ey11so3634408pad.12
 for <dev@dpdk.org>; Fri, 20 Jun 2014 16:58:06 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=XJGojo7d8SP0WBepfi/lVvUxnBNOJg1fphhfYPjSvZ0=;
 b=IS9Jl0zKWN5X4oF9uP3gb9+g0lTQOT4Tqib88TvAwNA/1vN0Iw82xSGae92B8YTThB
 CIv8qb+NUiq7WZIaKaFMsOadBt9fInJgcbWG0DVKiLONH9pZJ23wSrvBwGCYfbhxFoxj
 G7l1zDEcx/0CN2hR2bCmaf+TTyekbeXbW9gOTcRudkUswBDIigAKUF9OJ3jWQ/fwI3Dv
 sCxCmHbExKxaMwRYNKFLulE4U51jrYuqi9qWElDX01NFOPdwGmcXnpuwc0BxnW8vLjD7
 pkkpsAbdCbqKTsMSvPQw10bvACdnrgSs20CDt19LXKIFTZA7thgQIshok7U16SupAAEv
 Qs8w==
X-Gm-Message-State: ALoCoQlZkVUYz7SS0bsV68ChtreEWRyBdjQJ5zWJQ3DrsDjY30TTM+y0lS8IgMp/5XfX4yxwZO4Z
X-Received: by 10.68.213.74 with SMTP id nq10mr8755684pbc.4.1403308686587;
 Fri, 20 Jun 2014 16:58:06 -0700 (PDT)
Received: from nehalam.linuxnetplumber.net
 (static-50-53-83-51.bvtn.or.frontiernet.net. [50.53.83.51])
 by mx.google.com with ESMTPSA id bu1sm15277476pbb.54.2014.06.20.16.58.05
 for <multiple recipients>
 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
 Fri, 20 Jun 2014 16:58:06 -0700 (PDT)
Date: Fri, 20 Jun 2014 16:58:03 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Message-ID: <20140620165803.71f68c43@nehalam.linuxnetplumber.net>
In-Reply-To: <1403307270-28308-1-git-send-email-bruce.richardson@intel.com>
References: <E115CCD9D858EF4F90C690B0DCB4D897082CC6E5@IRSMSX103.ger.corp.intel.com>
 <1403307270-28308-1-git-send-email-bruce.richardson@intel.com>
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] EAL: fix usage of printf-like functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jun 2014 23:57:53 -0000

On Sat, 21 Jun 2014 00:34:30 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> +			(int)(strnlen(buf, sizeof(buf)) - sizeof("_config")),

minor nit, paren not needed here
			(int)strnlen(buf, sizeof...)

better yet change rte_snprintf() to take a size_t to make it compatiable with snprintf