From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pb0-f52.google.com (mail-pb0-f52.google.com
 [209.85.160.52]) by dpdk.org (Postfix) with ESMTP id 558DFB0FC
 for <dev@dpdk.org>; Tue, 24 Jun 2014 19:54:13 +0200 (CEST)
Received: by mail-pb0-f52.google.com with SMTP id rq2so537177pbb.39
 for <dev@dpdk.org>; Tue, 24 Jun 2014 10:54:31 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=KPX/vWlb+MGbvcxUGbt/zFtYUqheUN5hd/M0k8CfuUM=;
 b=WNHqCBs9pdPnpd+0D+jzGOGNgDc7ozrVabkOKkLZTJdYOeZ/G33Xh1M12IrDphq1Mx
 TMONdB++LAS9DqmrPHcRRe+1mhQqfp/BXvB5iQhNgkF/q68K0pHya2n7CsFeSxejHgy2
 PHkm75aKEbOay7KytswdfZBZW0z739HOdakjPUnnagw+xu7seYuxLgGm9x1PqHUYQgpK
 FzhyrkyECb0knsjZIafw5ymB4N1/HUulUrwLuh2cXShF69R56r3f+4/qv1TKTX0rkCEK
 0j5AFT4+RK62N2S4qMrNP52hn4Mn7nEFy3jZjG9Jo2hI8xpkz++M1UmFO2S2bbwRO3SV
 pkzw==
X-Gm-Message-State: ALoCoQm62LB2UJ2fdMyZPk3xPbr0PPlxiEagFn+ygbklzb6ECmN2AVZfj1ls1E9sGbIkRVkkju+g
X-Received: by 10.68.136.99 with SMTP id pz3mr3796119pbb.150.1403632470993;
 Tue, 24 Jun 2014 10:54:30 -0700 (PDT)
Received: from nehalam.linuxnetplumber.net
 (static-50-53-83-51.bvtn.or.frontiernet.net. [50.53.83.51])
 by mx.google.com with ESMTPSA id wk4sm4653327pab.5.2014.06.24.10.54.30
 for <multiple recipients>
 (version=TLSv1.2 cipher=RC4-SHA bits=128/128);
 Tue, 24 Jun 2014 10:54:30 -0700 (PDT)
Date: Tue, 24 Jun 2014 10:54:27 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Message-ID: <20140624105427.166c21bf@nehalam.linuxnetplumber.net>
In-Reply-To: <59AF69C657FD0841A61C55336867B5B02CEE3359@IRSMSX103.ger.corp.intel.com>
References: <20140624090253.140206a7@nehalam.linuxnetplumber.net>
 <59AF69C657FD0841A61C55336867B5B02CEE3359@IRSMSX103.ger.corp.intel.com>
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jun 2014 17:54:13 -0000

On Tue, 24 Jun 2014 17:39:52 +0000
"Richardson, Bruce" <bruce.richardson@intel.com> wrote:

> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> > Sent: Tuesday, June 24, 2014 9:03 AM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf
> > 
> > The function rte_snprintf serves no useful purpose. It is the
> > same as snprintf() for all valid inputs. Just remove it and
> > replace all uses in current code.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > 
> 
> NAK to this as is.
> Approve of replacing all instance of the rte_snprintf function with the standard version in all our code and libraries.
> However, rather than just removing the function completely, I think we should just flag the function as deprecated initially, and then later on look to remove it completely.
> 
> /Bruce

I want to get it out now rather than some 2 year life cycle.
The issue was discussed and marking it as deprecated breaks the build.
Alternate is removing all instances and adding:

#define rte_snprintf	snprintf

in header file for user compatiablity.