From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH DRAFT 1/2] ethdev: add buffered single pkt TX function to API
Date: Tue, 24 Jun 2014 16:05:45 -0700 [thread overview]
Message-ID: <20140624160545.136ad9e4@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1403649136-23551-2-git-send-email-bruce.richardson@intel.com>
On Tue, 24 Jun 2014 23:32:15 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:
>
> +static void
> +free_unsent_pkts(struct rte_mbuf **pkts, uint16_t unsent,
> + void *userdata __rte_unused)
> +{
> + unsigned i;
> + for (i = 0; i < unsent; i++)
> + rte_pktmbuf_free(pkts[i]);
> +}
> +
This should be moved into mbuf layer, and there it could be
optimized to do a rte_mempool_mp_put_bulk. This would speed
up operations becuase it would mean a single ring operation
per set rather per mbuf segment.
Of course, the optimization would have to handle the refcnt
issues.
next prev parent reply other threads:[~2014-06-24 23:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 22:32 [dpdk-dev] [RFC PATCH DRAFT 0/2] ethdev: Proposal to expand API for single-pkt-tx Bruce Richardson
2014-06-24 22:32 ` [dpdk-dev] [RFC PATCH DRAFT 1/2] ethdev: add buffered single pkt TX function to API Bruce Richardson
2014-06-24 23:05 ` Stephen Hemminger [this message]
2014-06-25 0:05 ` Richardson, Bruce
2014-06-24 23:07 ` Stephen Hemminger
2014-06-25 0:02 ` Richardson, Bruce
2014-06-24 22:32 ` [dpdk-dev] [RFC PATCH DRAFT 2/2] l2fwd: update l2fwd to use tx_buffer API Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624160545.136ad9e4@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).