From: Flavio Leitner <fbl@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net: get rid of SET_ETHTOOL_OPS
Date: Wed, 2 Jul 2014 10:07:23 -0300 [thread overview]
Message-ID: <20140702130723.GU5631@t520.home> (raw)
In-Reply-To: <5006516.KlozUPNl4J@xps13>
On Wed, Jul 02, 2014 at 11:48:51AM +0200, Thomas Monjalon wrote:
> Hi Flavio,
>
> 2014-07-01 15:19, Flavio Leitner:
> > The SET_ETHTOOL_OPS has been removed from upstream, so it
> > breaks the dpdk build with recent kernels.
> >
> > Signed-off-by: Flavio Leitner <fbl@redhat.com>
>
> You are removing SET_ETHTOOL_OPS calls.
Yes.
> In a previous patch, Aaro Koskinen made the choice to redefine the macro
> in kcompat files.
I missed that one.
> I don't know what will be the choice of Intel in the sourceforge base driver.
> So I've applied Aaro's patch as there are less modifications of the base
> driver:
> http://dpdk.org/browse/dpdk/commit/?id=e0b7ca0c0383411
Since the macro is a simple pointer assignment, I didn't see any reason for
keeping it around. But maybe I am missing something.
fbl
next prev parent reply other threads:[~2014-07-02 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 18:19 Flavio Leitner
2014-07-02 9:48 ` Thomas Monjalon
2014-07-02 13:07 ` Flavio Leitner [this message]
2014-07-02 15:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702130723.GU5631@t520.home \
--to=fbl@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).