From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 783CB959 for ; Mon, 14 Jul 2014 19:59:26 +0200 (CEST) Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63) (envelope-from ) id 1X6kXn-00043I-Kq; Mon, 14 Jul 2014 14:00:07 -0400 Received: from linville-x1.hq.tuxdriver.com (localhost.localdomain [127.0.0.1]) by linville-x1.hq.tuxdriver.com (8.14.8/8.14.6) with ESMTP id s6EHrWnk009703; Mon, 14 Jul 2014 13:53:32 -0400 Received: (from linville@localhost) by linville-x1.hq.tuxdriver.com (8.14.8/8.14.8/Submit) id s6EHrWDx009702; Mon, 14 Jul 2014 13:53:32 -0400 Date: Mon, 14 Jul 2014 13:53:31 -0400 From: "John W. Linville" To: Thomas Monjalon Message-ID: <20140714175330.GH27848@tuxdriver.com> References: <1405024369-30058-1-git-send-email-linville@tuxdriver.com> <13642580.3DAGicjMse@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13642580.3DAGicjMse@xps13> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2014 17:59:26 -0000 On Sat, Jul 12, 2014 at 12:30:34AM +0200, Thomas Monjalon wrote: > About the form of the patch, I have 2 comments: > > 1) A doc explaining the design, the dependencies and how it can be used would > be a great help. Could you write it in rst format? What is rst format? Are there other examples in the repository? > 2) checkpatch.pl returns these errors: > > ERROR:SPACING: space required before the open parenthesis '(' > #468: FILE: lib/librte_pmd_packet/rte_eth_packet.c:250: > + if(sockfd != -1) > > ERROR:SPACING: space required before the open parenthesis '(' > #471: FILE: lib/librte_pmd_packet/rte_eth_packet.c:253: > + if(sockfd != -1) > > ERROR:SPACING: spaces required around that '=' (ctx:VxV) > #712: FILE: lib/librte_pmd_packet/rte_eth_packet.c:494: > + ifr.ifr_name[ifnamelen]='\0'; OK. FWIW, at least the first two are slightly changed from what was copied from the PCAP driver. The other probably was a cut-n-paste error from another source. I'll post a V2 shortly... John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.