From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 53A0D68F3
 for <dev@dpdk.org>; Wed, 16 Jul 2014 14:34:51 +0200 (CEST)
Received: from [209.188.62.162] (helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1X7OQq-0006nM-Gf; Wed, 16 Jul 2014 08:35:40 -0400
Date: Wed, 16 Jul 2014 08:35:30 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20140716123530.GA22437@localhost.localdomain>
References: <1405024369-30058-1-git-send-email-linville@tuxdriver.com>
 <9007827.iVFoEikAOq@xps13> <20140714134616.GC27848@tuxdriver.com>
 <5622385.bvoogjtUK7@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5622385.bvoogjtUK7@xps13>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_pmd_packet: add PMD for
 AF_PACKET-based	virtual devices
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jul 2014 12:34:51 -0000

On Tue, Jul 15, 2014 at 11:27:45PM +0200, Thomas Monjalon wrote:
> 2014-07-14 09:46, John W. Linville:
> > On Sat, Jul 12, 2014 at 12:34:46AM +0200, Thomas Monjalon wrote:
> > > 2014-07-11 13:40, John W. Linville:
> > > > Is there an example of code in DPDK that requires specific kernel
> > > > versions?  What is the preferred method for coding such dependencies?
> > > 
> > > No there is no userspace code checking kernel version in DPDK.
> > > Feel free to use what you think the best method.
> > > Please keep in mind that checking version number is a maintenance
> > > nightmare
> > > because of backports (like RedHat do ;).
> > 
Actually, I feel the need to correct this (I know you're being humorous, but
just the same).  You don't have a maintenence nightmare on your hands because
RedHat backports kernel features, you have a nightmare maintenece situation on
your hands because the DPDK uses kernel features that were never meant to be
directly accessed outside of kernel space.
Neil

> > I suppose that it could be a configuration option?
> 
> If there is no other way to configure kernel-dependent features, we can add 
> options. But I feel that relying on a macro (#ifdef) would be better if such 
> macro exist.
> 
> -- 
> Thomas
>