From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 729F5959
 for <dev@dpdk.org>; Thu, 17 Jul 2014 23:42:20 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 17 Jul 2014 14:43:16 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.01,680,1400050800"; d="scan'208";a="545019924"
Received: from unknown (HELO localhost.localdomain) ([134.134.172.151])
 by orsmga001.jf.intel.com with ESMTP; 17 Jul 2014 14:43:16 -0700
Date: Thu, 17 Jul 2014 14:42:24 -0700
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <20140717214224.GA8602@localhost.localdomain>
References: <1404776219-6130-1-git-send-email-bruce.richardson@intel.com>
 <1404776219-6130-4-git-send-email-bruce.richardson@intel.com>
 <2593913.gKODuJYKZP@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2593913.gKODuJYKZP@xps13>
Organization: Intel Shannon Limited. Registered in Ireland.  Registered
 Office: Collinstown Industrial Park, Leixlip, County Kildare. Registered
 Number: 308263. Business address: Dromore House, East Park, Shannon, Co.
 Clare.
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/6] mk: Ensure correct detection of SSE4.2
 on FreeBSD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jul 2014 21:42:20 -0000

On Thu, Jul 17, 2014 at 11:35:46AM +0200, Thomas Monjalon wrote:
> Hi Bruce,
> 
> 2014-07-08 00:36, Bruce Richardson:
> > Add a special case to the native target makefile, where we check if
> > -march=native shows SSE4.2 support. If it does not, then not everything may
> > build, so we check if the hardware supports SSE4.2, and use a corei7 target
> > explicitly to get the SSE4.2 support.
> [...]
> >  MACHINE_CFLAGS = -march=native
> > +
> > +# on FreeBSD systems, sometimes the correct cputype is not picked up.
> > +# To get everything to compile, we need SSE4.2 support, so check if that is
> > +# reported by compiler. If not, check if the CPU actually supports it, and if
> > +# so, set the compilation target to be a corei7, minimum target with SSE4.2
> > +SSE42_SUPPORT=$(shell $(CC) -march=native -dM -E - < /dev/null | grep SSE4_2)
> > +ifeq ($(SSE42_SUPPORT),)
> > +  CPU_SSE42_SUPPORT=$(shell if [ -f /var/run/dmesg.boot ] ; then grep SSE4\.2 /var/run/dmesg.boot ; fi)
> > +  ifneq ($(CPU_SSE42_SUPPORT),)
> > +    MACHINE_CFLAGS= -march=corei7
> > +  endif
> > +endif
> 
> What do you think of this change?
> -  CPU_SSE42_SUPPORT=$(shell if [ -f /var/run/dmesg.boot ] ; then grep SSE4\.2 /var/run/dmesg.boot ; fi)
> +  CPU_SSE42_SUPPORT = $(shell grep SSE4\.2 /var/run/dmesg.boot 2>/dev/null)
> 
> It's simpler and should produce the same result.
> If you agree, I'll change it before applying.
>

I'm going to do up a second version of this patch to also re-enable the
ACL compile on BSD - as you pointed out in your other mail, so I'll include 
this change in a rev 2. That ok?

/Bruce