From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 0B4CF590F
 for <dev@dpdk.org>; Fri, 18 Jul 2014 18:14:18 +0200 (CEST)
Received: by mail-pa0-f42.google.com with SMTP id lf10so5702820pab.15
 for <dev@dpdk.org>; Fri, 18 Jul 2014 09:15:19 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:user-agent:date:from:to:cc:subject
 :references:mime-version:content-type:content-disposition;
 bh=2T13iUx0jcNzQ91f1Si/W7hNb4Xo9hq7maHsOJz9FRI=;
 b=bBGSggcXNWN0VBKiK7CttGDa7tAdwuK22xhOjvPGYwu+1sGvTrZ4KhG3rudTlO0Xzn
 J8Gt/fqkD3pv2dWcNg9gvvAZ3uT03v3iT5PC7vCapBGiIoiftTbmkI0J3uFruTCMNVkS
 xxMDNy6YhSxo9MNq0mIdPv+3bI0EigQA0AfizjuUMKB5sUIC2z85Vur3gdVfESIM3wAZ
 4S4w2AviFYd1ILkIugnA0EgMCNLWw54G8cHx7cnN9eAMUPI1RDSAkoIC631KeRuBDM3H
 wBK8gGP0FCta/UF1lWSj4CsgFgjqDvsUHOByIecL9R+teQGmhfqAzQh1MU0e0lGQjowS
 SyRQ==
X-Gm-Message-State: ALoCoQkARWcMhjKmKngsG0e//0RwsSiqmdGzqJheF5ZMiUDk8fTyCmJ/QqSj7d45G8qtmb61KwkN
X-Received: by 10.66.66.35 with SMTP id c3mr6348844pat.79.1405700119563;
 Fri, 18 Jul 2014 09:15:19 -0700 (PDT)
Received: from localhost (static-50-53-66-61.bvtn.or.frontiernet.net.
 [50.53.66.61])
 by mx.google.com with ESMTPSA id k9sm3493083pdl.52.2014.07.18.09.15.18
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 18 Jul 2014 09:15:18 -0700 (PDT)
Message-Id: <20140718161521.323237303@networkplumber.org>
User-Agent: quilt/0.63-1
Date: Fri, 18 Jul 2014 09:14:53 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <20140718161447.020882834@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Disposition: inline; filename=igb_uio-mode-param-ro.patch
Cc: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 06/10] igb_uio: make irq mode param read-only
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jul 2014 16:14:19 -0000

The module parameter is read-only since changing mode after loading
isn't going to work.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c	2014-07-18 08:42:54.028654483 -0700
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c	2014-07-18 08:42:54.028654483 -0700
@@ -721,7 +721,7 @@ igbuio_pci_exit_module(void)
 module_init(igbuio_pci_init_module);
 module_exit(igbuio_pci_exit_module);
 
-module_param(intr_mode, charp, S_IRUGO | S_IWUSR);
+module_param(intr_mode, charp, S_IRUGO);
 MODULE_PARM_DESC(intr_mode,
 "igb_uio interrupt mode (default=msix):\n"
 "    " RTE_INTR_MODE_MSIX_NAME "       Use MSIX interrupt\n"